[GitHub] [skywalking] wu-sheng commented on a change in pull request #5009: Java agent memory leak when enhance `Worker thread` at use Thread Pool

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #5009:
URL: https://github.com/apache/skywalking/pull/5009#discussion_r448675317



##########
File path: docs/en/FAQ/Memory-leak-enhance-Worker-thread.md
##########
@@ -0,0 +1,32 @@
+### Problem 
+When using a thread pool, `TraceSegment` data in a thread cannot be reported and there are memory data that cannot be recycled (memory leaks)
+
+### Example
+``` java
+    ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor();
+    executor.setThreadFactory(r -> new Thread(RunnableWrapper.of(r)));
+```
+
+### Reason
+
+* Worker threads are enhanced, when using thread pool. 
+* According to the SkyWalking Java Agent design, when you want to trace cross thread, you need to enhance the task thread.
+
+### Resolve
+
+* When using `Thread Schedule Framework`
+Checked SkyWalking Thread Schedule Framework at [SkyWalking Java agent supported list](../setup/service-agent/java-agent/Supported-list.md), such as Spring FrameWork @Async, such as Spring @Async, which can implement tracing without any modification. 

Review comment:
       ```suggestion
   Checked SkyWalking Thread Schedule Framework at [SkyWalking Java agent supported list](../setup/service-agent/java-agent/Supported-list.md), such as Spring FrameWork @Async, which can implement tracing without any modification. 
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org