You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/10/19 22:07:50 UTC

Review Request 63172: Added and used more v1 scheduler API test helpers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63172/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
-------

Added and used more v1 scheduler API test helpers.


Diffs
-----

  src/tests/default_executor_tests.cpp b3c1d82c8286d96fe20ecb2cb01bc3882cef4940 
  src/tests/mesos.hpp 24d220e292bc1e137992e8f81484477b62bd0896 


Diff: https://reviews.apache.org/r/63172/diff/1/


Testing
-------

`sudo bin/mesos-tests.sh --gtest_filter="*DefaultExecutorTest*" --gtest_break_on_failure` passed on GNU/Linux.


Thanks,

Gaston Kleiman


Re: Review Request 63172: Added and used more v1 scheduler API test helpers.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63172/#review190655
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Oct. 20, 2017, 12:24 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63172/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2017, 12:24 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added and used more v1 scheduler API test helpers.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp b3c1d82c8286d96fe20ecb2cb01bc3882cef4940 
>   src/tests/mesos.hpp 3cc70b64cfb5f13b8f25a74f4a1fca2ea8d6edcb 
> 
> 
> Diff: https://reviews.apache.org/r/63172/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*DefaultExecutorTest*" --gtest_break_on_failure` passed on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Re: Review Request 63172: Added and used more v1 scheduler API test helpers.

Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63172/
-----------------------------------------------------------

(Updated Oct. 19, 2017, 5:24 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Added and used more v1 scheduler API test helpers.


Diffs (updated)
-----

  src/tests/default_executor_tests.cpp b3c1d82c8286d96fe20ecb2cb01bc3882cef4940 
  src/tests/mesos.hpp 3cc70b64cfb5f13b8f25a74f4a1fca2ea8d6edcb 


Diff: https://reviews.apache.org/r/63172/diff/2/

Changes: https://reviews.apache.org/r/63172/diff/1-2/


Testing
-------

`sudo bin/mesos-tests.sh --gtest_filter="*DefaultExecutorTest*" --gtest_break_on_failure` passed on GNU/Linux.


Thanks,

Gaston Kleiman