[GitHub] [spark] imback82 commented on a change in pull request #30936: [SPARK-33918][SQL] UnresolvedView should retain SQL text position for DDL commands

[GitBox <gi...@apache.org>]

imback82 commented on a change in pull request #30936:
URL: https://github.com/apache/spark/pull/30936#discussion_r549059215



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala
##########
@@ -52,8 +52,8 @@ case class UnresolvedTable(
 case class UnresolvedView(
     multipartIdentifier: Seq[String],
     commandName: String,
-    allowTemp: Boolean = true,
-    relationTypeMismatchHint: Option[String] = None) extends LeafNode {
+    allowTemp: Boolean,
+    relationTypeMismatchHint: Option[String]) extends LeafNode {

Review comment:
       The defaults are moved to `createUnresolvedView`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org