[GitHub] [iceberg] danielcweeks commented on pull request #1844: AWS: support custom client configuration

[GitBox <gi...@apache.org>]

danielcweeks commented on pull request #1844:
URL: https://github.com/apache/iceberg/pull/1844#issuecomment-748209624


   @jackye1995 thanks for breaking this apart, I think that really helps and we can follow on with the STS implementation and discuss the dynamic catalog configuration separately.
   
   As to the `AwsClientFactory` being serializable,  I agree with you (my concern was more that it was part of AwsProperties which felt awkward.).  This looks good.
   
   Appears there are some checkstyle failures, but other than that, I'm good with this.
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org