You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Subramanya-Veeregowda (via GitHub)" <gi...@apache.org> on 2026/04/01 09:52:51 UTC
[PR] Fix serial warning in starter and example archetypes [beam]
Subramanya-Veeregowda opened a new pull request, #38028:
URL: https://github.com/apache/beam/pull/38028
Adds @SuppressWarning("serial") to anonymous classes in starter and example archetypes to avoid serialization warnings in IDEs.
this aligns with excepted usage where DoFn and other functions are serialized.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "Subramanya-Veeregowda (via GitHub)" <gi...@apache.org>.
Subramanya-Veeregowda commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4335481279
@stankiewicz This change addresses the issue where starter and example archetypes show
serialization warnings in IDEs due to anonymous classes.
I added @SuppressWarnings("serial") to those classes so that the examples
align with expected Beam usage (where DoFn and similar constructs are serialized),
and users are not presented with unnecessary warnings when using the starter templates.
Please let me know if you'd like me to refine this further.
Fixes #18120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4316049998
> @stankiewicz Please give review on this?
there are conflicts -please rebase and resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4172830869
> @stankiewicz should remove it and re-commit it again or is it fine with this?
yes please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "Subramanya-Veeregowda (via GitHub)" <gi...@apache.org>.
Subramanya-Veeregowda commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4172467018
@stankiewicz should remove it and re-commit it again or is it fine with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "Subramanya-Veeregowda (via GitHub)" <gi...@apache.org>.
Subramanya-Veeregowda commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4315263240
@stankiewicz Please give review on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "Subramanya-Veeregowda (via GitHub)" <gi...@apache.org>.
Subramanya-Veeregowda commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4168922531
This PR adds @SuppressWarnings("serial") to anonymous classes in both starter and example archetypes to avoid IDE warnings.
Tested locally for starter module. Example archetype build requires shell environment (generate-sources.sh), so relying on CI for validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4499883734
Closing since currently the code changes don't match the description (and they don't seem to add value)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "Subramanya-Veeregowda (via GitHub)" <gi...@apache.org>.
Subramanya-Veeregowda commented on code in PR #38028:
URL: https://github.com/apache/beam/pull/38028#discussion_r3023681971
##########
sdks/java/maven-archetypes/starter/src/main/resources/archetype-resources/src/main/java/StarterPipeline.java:
##########
@@ -51,16 +51,20 @@ public static void main(String[] args) {
PipelineOptionsFactory.fromArgs(args).withValidation().create());
p.apply(Create.of("Hello", "World"))
- .apply(MapElements.via(new SimpleFunction<String, String>() {
- @Override
- public String apply(String input) {
- return input.toUpperCase();
- }
- }))
- .apply(ParDo.of(new DoFn<String, Void>() {
+ .apply(
+ MapElements.via(
+ new SimpleFunction<String, String>() {
+ @Override
+ public String apply(String input) {
+ return input.toUpperCase();
+ }
+ }))
+ .apply(
+ ParDo.of(
+ new DoFn<String, Void>() {
@ProcessElement
- public void processElement(ProcessContext c) {
- LOG.info(c.element());
+ public void processElement(@Element String element) {
Review Comment:
@stankiewicz checks passed after updating the request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "Subramanya-Veeregowda (via GitHub)" <gi...@apache.org>.
Subramanya-Veeregowda commented on code in PR #38028:
URL: https://github.com/apache/beam/pull/38028#discussion_r3023545696
##########
sdks/java/maven-archetypes/starter/src/main/resources/archetype-resources/src/main/java/StarterPipeline.java:
##########
@@ -51,16 +51,20 @@ public static void main(String[] args) {
PipelineOptionsFactory.fromArgs(args).withValidation().create());
p.apply(Create.of("Hello", "World"))
- .apply(MapElements.via(new SimpleFunction<String, String>() {
- @Override
- public String apply(String input) {
- return input.toUpperCase();
- }
- }))
- .apply(ParDo.of(new DoFn<String, Void>() {
+ .apply(
+ MapElements.via(
+ new SimpleFunction<String, String>() {
+ @Override
+ public String apply(String input) {
+ return input.toUpperCase();
+ }
+ }))
+ .apply(
+ ParDo.of(
+ new DoFn<String, Void>() {
@ProcessElement
- public void processElement(ProcessContext c) {
- LOG.info(c.element());
+ public void processElement(@Element String element) {
Review Comment:
Oops! i was in a hurry, update coming soon!. 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on code in PR #38028:
URL: https://github.com/apache/beam/pull/38028#discussion_r3024153468
##########
sdks/java/maven-archetypes/starter/src/main/resources/archetype-resources/src/main/java/StarterPipeline.java:
##########
@@ -51,16 +51,20 @@ public static void main(String[] args) {
PipelineOptionsFactory.fromArgs(args).withValidation().create());
p.apply(Create.of("Hello", "World"))
- .apply(MapElements.via(new SimpleFunction<String, String>() {
- @Override
- public String apply(String input) {
- return input.toUpperCase();
- }
- }))
- .apply(ParDo.of(new DoFn<String, Void>() {
+ .apply(
+ MapElements.via(
+ new SimpleFunction<String, String>() {
+ @Override
+ public String apply(String input) {
+ return input.toUpperCase();
+ }
+ }))
+ .apply(
+ ParDo.of(
+ new DoFn<String, Void>() {
@ProcessElement
- public void processElement(ProcessContext c) {
- LOG.info(c.element());
+ public void processElement(@Element String element) {
Review Comment:
actually, I'm wrong, sorry. There is already org.apache.beam.sdk.transforms.DoFn and this is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "Subramanya-Veeregowda (via GitHub)" <gi...@apache.org>.
Subramanya-Veeregowda commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4321188183
@stankiewicz Can u go through, this i have resolved the conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4168901443
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses build-time warnings related to serialization in anonymous classes within the project's starter archetypes. By explicitly suppressing these warnings, the codebase maintains cleaner logs and better IDE integration for developers using these templates.
### Highlights
* **Code Cleanup**: Added @SuppressWarnings("serial") annotations to anonymous classes within the starter archetype to resolve IDE serialization warnings.
🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4320322314
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/38028?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 57.63%. Comparing base ([`1cb2a71`](https://app.codecov.io/gh/apache/beam/commit/1cb2a711aa672bc743419511de3d922ea73a90cb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5b2b417`](https://app.codecov.io/gh/apache/beam/commit/5b2b4176b587175c015ef707a6e6ebbc9fd72072?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 25 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #38028 +/- ##
============================================
+ Coverage 54.61% 57.63% +3.01%
- Complexity 1689 13344 +11655
============================================
Files 1067 2604 +1537
Lines 168155 266683 +98528
Branches 1226 10994 +9768
============================================
+ Hits 91844 153712 +61868
- Misses 74116 107183 +33067
- Partials 2195 5788 +3593
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/38028/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [java](https://app.codecov.io/gh/apache/beam/pull/38028/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.18% <ø> (-4.17%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/38028?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4325799962
so what is this change about after all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4336042448
please read your comment and your code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4169905701
Assigning reviewers:
R: @kennknowles for label java.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on code in PR #38028:
URL: https://github.com/apache/beam/pull/38028#discussion_r3023464048
##########
sdks/java/maven-archetypes/starter/src/main/resources/archetype-resources/src/main/java/StarterPipeline.java:
##########
@@ -51,16 +51,20 @@ public static void main(String[] args) {
PipelineOptionsFactory.fromArgs(args).withValidation().create());
p.apply(Create.of("Hello", "World"))
- .apply(MapElements.via(new SimpleFunction<String, String>() {
- @Override
- public String apply(String input) {
- return input.toUpperCase();
- }
- }))
- .apply(ParDo.of(new DoFn<String, Void>() {
+ .apply(
+ MapElements.via(
+ new SimpleFunction<String, String>() {
+ @Override
+ public String apply(String input) {
+ return input.toUpperCase();
+ }
+ }))
+ .apply(
+ ParDo.of(
+ new DoFn<String, Void>() {
@ProcessElement
- public void processElement(ProcessContext c) {
- LOG.info(c.element());
+ public void processElement(@Element String element) {
Review Comment:
you are missing import:
import org.apache.beam.sdk.transforms.DoFn.Element;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #38028:
URL: https://github.com/apache/beam/pull/38028#issuecomment-4325802121
waiting on author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix serial warning in starter and example archetypes [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #38028: Fix serial warning in starter and example archetypes
URL: https://github.com/apache/beam/pull/38028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org