[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1248: refactor: enable warning on unused result

[GitBox <gi...@apache.org>]

acelyc111 commented on code in PR #1248:
URL: https://github.com/apache/incubator-pegasus/pull/1248#discussion_r1029405866


##########
src/block_service/directio_writable_file.cpp:
##########
@@ -96,12 +103,16 @@ bool direct_io_writable_file::finalize()
 
     if (_offset > 0) {
         if (::write(_fd, _buffer, _buffer_size) != _buffer_size) {

Review Comment:
   We can do that, but not in this patch.
   TODO added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org