You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Roiocam (via GitHub)" <gi...@apache.org> on 2023/09/20 16:28:31 UTC

[GitHub] [incubator-pekko-management] Roiocam opened a new pull request, #128: docs: remove unrelated doc

Roiocam opened a new pull request, #128:
URL: https://github.com/apache/incubator-pekko-management/pull/128

   We are the community, which means we must support them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-management] Roiocam commented on a diff in pull request #128: docs: remove unrelated doc

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #128:
URL: https://github.com/apache/incubator-pekko-management/pull/128#discussion_r1331957502


##########
docs/src/main/paradox/discovery/consul.md:
##########
@@ -2,9 +2,8 @@
 
 @@@ warning
 
-This module is community maintained and the Lightbend subscription doesn't cover support for this module.
-  It is also marked as @extref:[may change](pekko:common/may-change.html).
-  That means that the API, configuration or semantics can change without warning or deprecation period.
+It is marked as @extref:[may change](pekko:common/may-change.html).

Review Comment:
   Nice input, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #128: docs: remove unrelated doc

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #128:
URL: https://github.com/apache/incubator-pekko-management/pull/128#discussion_r1331932614


##########
docs/src/main/paradox/discovery/consul.md:
##########
@@ -2,9 +2,8 @@
 
 @@@ warning
 
-This module is community maintained and the Lightbend subscription doesn't cover support for this module.
-  It is also marked as @extref:[may change](pekko:common/may-change.html).
-  That means that the API, configuration or semantics can change without warning or deprecation period.
+It is marked as @extref:[may change](pekko:common/may-change.html).

Review Comment:
   Could you change this to `This module is marked ...` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-management] Roiocam commented on a diff in pull request #128: docs: remove unrelated doc

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #128:
URL: https://github.com/apache/incubator-pekko-management/pull/128#discussion_r1331956959


##########
docs/src/main/paradox/discovery/marathon.md:
##########
@@ -2,9 +2,8 @@
 
 @@@ warning
 
-This module is community maintained and the Lightbend subscription doesn't cover support for this module.
-  It is also marked as @extref:[may change](pekko:common/may-change.html).
-  That means that the API, configuration or semantics can change without warning or deprecation period.
+It is marked as @extref:[may change](pekko:common/may-change.html).

Review Comment:
   I will fix this after sometime, i have to build the document and verify first, and then i will fix this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-management] Roiocam closed pull request #128: docs: remove unrelated doc

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam closed pull request #128: docs: remove unrelated doc
URL: https://github.com/apache/incubator-pekko-management/pull/128


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #128: docs: remove unrelated doc

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #128:
URL: https://github.com/apache/incubator-pekko-management/pull/128#discussion_r1331917001


##########
docs/src/main/paradox/discovery/marathon.md:
##########
@@ -2,9 +2,8 @@
 
 @@@ warning
 
-This module is community maintained and the Lightbend subscription doesn't cover support for this module.
-  It is also marked as @extref:[may change](pekko:common/may-change.html).
-  That means that the API, configuration or semantics can change without warning or deprecation period.
+It is marked as @extref:[may change](pekko:common/may-change.html).

Review Comment:
   Thanks but could you change this to `This module is marked ...`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org