You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/15 05:01:16 UTC
[GitHub] [spark] LuciferYang opened a new pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
LuciferYang opened a new pull request #31188:
URL: https://github.com/apache/spark/pull/31188
### What changes were proposed in this pull request?
This pr use `exists` or `forall` to simplify `filter + emptiness check`, it's semantically consistent, but looks simpler. The rule as follow:
- `seq.filter(p).size == 0)` -> `!seq.exists(p)`
- `seq.filter(p).length > 0` -> `seq.exists(p)`
- `seq.filterNot(p).isEmpty` -> `seq.forall(p)`
- `seq.filterNot(p).nonEmpty` -> `!seq.forall(p)`
### Why are the changes needed?
Code Simpilefications.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the Jenkins or GitHub Action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31188:
URL: https://github.com/apache/spark/pull/31188#issuecomment-760663659
**[Test build #134080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134080/testReport)** for PR 31188 at commit [`c9e3f3e`](https://github.com/apache/spark/commit/c9e3f3ec4b7d54baaca8ce3469daa8a51e354719).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31188:
URL: https://github.com/apache/spark/pull/31188#issuecomment-760663659
**[Test build #134080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134080/testReport)** for PR 31188 at commit [`c9e3f3e`](https://github.com/apache/spark/commit/c9e3f3ec4b7d54baaca8ce3469daa8a51e354719).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31188:
URL: https://github.com/apache/spark/pull/31188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #31188:
URL: https://github.com/apache/spark/pull/31188#issuecomment-760800249
thx @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31188:
URL: https://github.com/apache/spark/pull/31188#issuecomment-760753257
**[Test build #134080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134080/testReport)** for PR 31188 at commit [`c9e3f3e`](https://github.com/apache/spark/commit/c9e3f3ec4b7d54baaca8ce3469daa8a51e354719).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31188:
URL: https://github.com/apache/spark/pull/31188#issuecomment-760765519
Merged to branch-3.1.
Thanks, @LuciferYang.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31188:
URL: https://github.com/apache/spark/pull/31188#issuecomment-760713220
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38666/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31188:
URL: https://github.com/apache/spark/pull/31188#issuecomment-760756110
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134080/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31188:
URL: https://github.com/apache/spark/pull/31188#issuecomment-760697233
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38666/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31188:
URL: https://github.com/apache/spark/pull/31188#issuecomment-760756110
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134080/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31188:
URL: https://github.com/apache/spark/pull/31188#issuecomment-760713220
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38666/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31188: [SPARK-34118][CORE][SQL][3.1] Replaces filter and check for emptiness with exists or forall
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31188:
URL: https://github.com/apache/spark/pull/31188#issuecomment-760684233
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38666/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org