You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/12/05 20:42:00 UTC

[GitHub] [trafficcontrol] asheikm opened a new pull request #6406: add go.mod and update README

asheikm opened a new pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406


   <!--
   Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
   If this closes or relates to an existing issue, please reference it using one of the following:
   
   Closes: #ISSUE
   Related: #ISSUE
   
   If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://apache.org/security regarding vulnerability disclosure.
   -->
   
   
   <!-- **^ Add meaningful description above** --><hr>
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this PR.
   Feel free to add the name of a tool or script that is affected but not on the list.
   -->
   
   - unknown
   
   ## What is the best way to verify this PR?
   This PR adds go.mod, go.sum files and updated the README to build the binary for this experimental golang traffic router
   cd to experimental/traffic_router_golang
   go build -o traffic_router . 
   
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   No
   
   
   ## PR submission checklist
   
   - [x] This PR has documentation
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6406: add go.mod and update README

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#discussion_r765075888



##########
File path: experimental/traffic_router_golang/README.md
##########
@@ -17,4 +17,60 @@
     under the License.
 -->
 
+# Traffic Router 
+
 This is a prototype of Traffic Router's HTTP side in Golang.
+
+# How to build
+
+To get this app running locally:
+
+- Clone this repo
+- Install Golang programming language ([instructions](https://golang.org/doc/install))
+
+
+# Configuration
+
+Sample configuration file(cfg.json) available in traffic_router_golang directory, please add coveragezone files to path specified in cfg.json
+   
+
+# Build
+
+Compile and generate binary:
+
+   - `cd traffic_router_goland`
+   - `go mod download`

Review comment:
       As you pointed out, this should be `go mod vendor`, not `go mod download`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6406: Update README help doc for experimental package traffic_router_golang

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#discussion_r765134613



##########
File path: experimental/traffic_router_golang/README.md
##########
@@ -17,4 +17,51 @@
     under the License.
 -->
 
+# Traffic Router 
+
 This is a prototype of Traffic Router's HTTP side in Golang.
+
+# How to build
+
+To get this app running locally:
+
+- Clone this repo
+- Install Golang programming language ([instructions](https://golang.org/doc/install))
+
+
+# Configuration
+
+Sample configuration file(cfg.json) available in traffic_router_golang directory, please add coveragezone files to path specified in cfg.json
+   
+
+# Build
+
+Compile and generate binary:
+
+   - `cd traffic_router_goland`
+   - `go mod vendor`
+   - `go build` #This will generate binary file traffic_router_golang)
+
+# Unit Test
+    
+   - Run `go test ./...` from traffic_router_golang directory
+     
+     ```$ go test ./...
+		?       traffic_router_golang   [no test files]
+		?       traffic_router_golang/availableservers  [no test files]
+		?       traffic_router_golang/cgsrch    [no test files]
+		?       traffic_router_golang/config    [no test files]
+		?       traffic_router_golang/coveragezone      [no test files]
+		?       traffic_router_golang/crconfig  [no test files]
+		?       traffic_router_golang/crconfigdsservers [no test files]
+		?       traffic_router_golang/crconfigpoller    [no test files]
+		?       traffic_router_golang/crconfigregex     [no test files]
+		?       traffic_router_golang/crstates  [no test files]
+		?       traffic_router_golang/crstatespoller    [no test files]
+		?       traffic_router_golang/fetch     [no test files]
+		?       traffic_router_golang/httpsrvr  [no test files]
+		?       traffic_router_golang/ipmap     [no test files]
+		?       traffic_router_golang/nextcache [no test files]
+		ok      traffic_router_golang/quadtree  0.526s
+		?       traffic_router_golang/toutil    [no test files]

Review comment:
       Oh, I missed 6d5783ceec. Looks good




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman merged pull request #6406: Update README help doc for experimental package traffic_router_golang

Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on pull request #6406: Update README help doc

Posted by GitBox <gi...@apache.org>.
asheikm commented on pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#issuecomment-989029843


   > The title of #6406, "add go.mod and update README" is no longer accurate, since no `go.mod` file is being added.
   
   Changed the title


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6406: Update README help doc for experimental package traffic_router_golang

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#discussion_r765134066



##########
File path: experimental/traffic_router_golang/README.md
##########
@@ -17,4 +17,51 @@
     under the License.
 -->
 
+# Traffic Router 
+
 This is a prototype of Traffic Router's HTTP side in Golang.
+
+# How to build
+
+To get this app running locally:
+
+- Clone this repo
+- Install Golang programming language ([instructions](https://golang.org/doc/install))
+
+
+# Configuration
+
+Sample configuration file(cfg.json) available in traffic_router_golang directory, please add coveragezone files to path specified in cfg.json
+   
+
+# Build
+
+Compile and generate binary:
+
+   - `cd traffic_router_goland`
+   - `go mod vendor`
+   - `go build` #This will generate binary file traffic_router_golang)
+
+# Unit Test
+    
+   - Run `go test ./...` from traffic_router_golang directory
+     
+     ```$ go test ./...
+		?       traffic_router_golang   [no test files]
+		?       traffic_router_golang/availableservers  [no test files]
+		?       traffic_router_golang/cgsrch    [no test files]
+		?       traffic_router_golang/config    [no test files]
+		?       traffic_router_golang/coveragezone      [no test files]
+		?       traffic_router_golang/crconfig  [no test files]
+		?       traffic_router_golang/crconfigdsservers [no test files]
+		?       traffic_router_golang/crconfigpoller    [no test files]
+		?       traffic_router_golang/crconfigregex     [no test files]
+		?       traffic_router_golang/crstates  [no test files]
+		?       traffic_router_golang/crstatespoller    [no test files]
+		?       traffic_router_golang/fetch     [no test files]
+		?       traffic_router_golang/httpsrvr  [no test files]
+		?       traffic_router_golang/ipmap     [no test files]
+		?       traffic_router_golang/nextcache [no test files]
+		ok      traffic_router_golang/quadtree  0.526s
+		?       traffic_router_golang/toutil    [no test files]

Review comment:
       I still get full package paths when running the tests from outside the GOPATH. Not sure why you don't get full package paths, but the README should have them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on a change in pull request #6406: add go.mod and update README

Posted by GitBox <gi...@apache.org>.
asheikm commented on a change in pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#discussion_r765067412



##########
File path: experimental/traffic_router_golang/go.mod
##########
@@ -0,0 +1,21 @@
+module traffic_router_golang

Review comment:
       Thanks, but got some errors, fixed it by running `go mod vendor` after running `go mod download`
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6406: add go.mod and update README

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#discussion_r765073521



##########
File path: experimental/traffic_router_golang/go.mod
##########
@@ -0,0 +1,21 @@
+module traffic_router_golang

Review comment:
       Ah right, `go mod vendor` is necessary since we vendor most dependencies already.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6406: add go.mod and update README

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#discussion_r764949874



##########
File path: experimental/traffic_router_golang/go.mod
##########
@@ -0,0 +1,21 @@
+module traffic_router_golang

Review comment:
       Using Go 1.17.4,
   ```
   cd experimental/traffic_router_golang
   go mod download
   go build
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on a change in pull request #6406: add go.mod and update README

Posted by GitBox <gi...@apache.org>.
asheikm commented on a change in pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#discussion_r765076401



##########
File path: experimental/traffic_router_golang/README.md
##########
@@ -17,4 +17,60 @@
     under the License.
 -->
 
+# Traffic Router 
+
 This is a prototype of Traffic Router's HTTP side in Golang.
+
+# How to build
+
+To get this app running locally:
+
+- Clone this repo
+- Install Golang programming language ([instructions](https://golang.org/doc/install))
+
+
+# Configuration
+
+Sample configuration file(cfg.json) available in traffic_router_golang directory, please add coveragezone files to path specified in cfg.json
+   
+
+# Build
+
+Compile and generate binary:
+
+   - `cd traffic_router_goland`
+   - `go mod download`

Review comment:
       ok, let me modify




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on a change in pull request #6406: add go.mod and update README

Posted by GitBox <gi...@apache.org>.
asheikm commented on a change in pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#discussion_r764922883



##########
File path: experimental/traffic_router_golang/go.mod
##########
@@ -0,0 +1,21 @@
+module traffic_router_golang

Review comment:
       > There is already a [`go.mod`](https://github.com/apache/trafficcontrol/blob/master/go.mod) file in the top-level directory. It's convenient to track Go dependencies for the whole project in one place, and if the experimental traffic_router_golang package had its own `go.mod`, the top-level `go.mod` would not track its dependencies.
   
   Do you know how to compile package level for example to compile traffic_router_golang , I tied using the top level go.mod to build the package, but failed to do.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on a change in pull request #6406: Update README help doc for experimental package traffic_router_golang

Posted by GitBox <gi...@apache.org>.
asheikm commented on a change in pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#discussion_r765100547



##########
File path: experimental/traffic_router_golang/README.md
##########
@@ -17,4 +17,51 @@
     under the License.
 -->
 
+# Traffic Router 
+
 This is a prototype of Traffic Router's HTTP side in Golang.
+
+# How to build
+
+To get this app running locally:
+
+- Clone this repo
+- Install Golang programming language ([instructions](https://golang.org/doc/install))
+
+
+# Configuration
+
+Sample configuration file(cfg.json) available in traffic_router_golang directory, please add coveragezone files to path specified in cfg.json
+   
+
+# Build
+
+Compile and generate binary:
+
+   - `cd traffic_router_goland`
+   - `go mod vendor`
+   - `go build` #This will generate binary file traffic_router_golang)
+
+# Unit Test
+    
+   - Run `go test ./...` from traffic_router_golang directory
+     
+     ```$ go test ./...
+		?       traffic_router_golang   [no test files]
+		?       traffic_router_golang/availableservers  [no test files]
+		?       traffic_router_golang/cgsrch    [no test files]
+		?       traffic_router_golang/config    [no test files]
+		?       traffic_router_golang/coveragezone      [no test files]
+		?       traffic_router_golang/crconfig  [no test files]
+		?       traffic_router_golang/crconfigdsservers [no test files]
+		?       traffic_router_golang/crconfigpoller    [no test files]
+		?       traffic_router_golang/crconfigregex     [no test files]
+		?       traffic_router_golang/crstates  [no test files]
+		?       traffic_router_golang/crstatespoller    [no test files]
+		?       traffic_router_golang/fetch     [no test files]
+		?       traffic_router_golang/httpsrvr  [no test files]
+		?       traffic_router_golang/ipmap     [no test files]
+		?       traffic_router_golang/nextcache [no test files]
+		ok      traffic_router_golang/quadtree  0.526s
+		?       traffic_router_golang/toutil    [no test files]

Review comment:
       You are right, I ran this under directory which is not in GOPATH, so when running from go path, i got the same result as yours, 
   ```
   $ go test ./...
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang     [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/availableservers    [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/cgsrch      [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/config      [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/coveragezone        [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/crconfig    [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/crconfigdsservers   [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/crconfigpoller      [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/crconfigregex       [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/crstates    [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/crstatespoller      [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/fetch       [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/httpsrvr    [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/ipmap       [no test files]
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/nextcache   [no test files]
   ok      github.com/apache/trafficcontrol/experimental/traffic_router_golang/quadtree    1.190s
   ?       github.com/apache/trafficcontrol/experimental/traffic_router_golang/toutil      [no test files]
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on pull request #6406: Update README help doc for experimental package traffic_router_golang

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#issuecomment-989085810


   Looks good! thank you for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6406: add go.mod and update README

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#discussion_r764355079



##########
File path: experimental/traffic_router_golang/go.mod
##########
@@ -0,0 +1,21 @@
+module traffic_router_golang

Review comment:
       There is already a [`go.mod`](https://github.com/apache/trafficcontrol/blob/master/go.mod) file in the top-level directory. It's convenient to track Go dependencies for the whole project in one place, and if the experimental traffic_router_golang package had its own `go.mod`, the top-level `go.mod` would not track its dependencies.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6406: Update README help doc for experimental package traffic_router_golang

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#discussion_r765094959



##########
File path: experimental/traffic_router_golang/README.md
##########
@@ -17,4 +17,51 @@
     under the License.
 -->
 
+# Traffic Router 
+
 This is a prototype of Traffic Router's HTTP side in Golang.
+
+# How to build
+
+To get this app running locally:
+
+- Clone this repo
+- Install Golang programming language ([instructions](https://golang.org/doc/install))
+
+
+# Configuration
+
+Sample configuration file(cfg.json) available in traffic_router_golang directory, please add coveragezone files to path specified in cfg.json
+   
+
+# Build
+
+Compile and generate binary:
+
+   - `cd traffic_router_goland`
+   - `go mod vendor`
+   - `go build` #This will generate binary file traffic_router_golang)
+
+# Unit Test
+    
+   - Run `go test ./...` from traffic_router_golang directory
+     
+     ```$ go test ./...
+		?       traffic_router_golang   [no test files]
+		?       traffic_router_golang/availableservers  [no test files]
+		?       traffic_router_golang/cgsrch    [no test files]
+		?       traffic_router_golang/config    [no test files]
+		?       traffic_router_golang/coveragezone      [no test files]
+		?       traffic_router_golang/crconfig  [no test files]
+		?       traffic_router_golang/crconfigdsservers [no test files]
+		?       traffic_router_golang/crconfigpoller    [no test files]
+		?       traffic_router_golang/crconfigregex     [no test files]
+		?       traffic_router_golang/crstates  [no test files]
+		?       traffic_router_golang/crstatespoller    [no test files]
+		?       traffic_router_golang/fetch     [no test files]
+		?       traffic_router_golang/httpsrvr  [no test files]
+		?       traffic_router_golang/ipmap     [no test files]
+		?       traffic_router_golang/nextcache [no test files]
+		ok      traffic_router_golang/quadtree  0.526s
+		?       traffic_router_golang/toutil    [no test files]

Review comment:
       I get different output when running `go test ./...`:
   
   ```
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/availableservers	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/cgsrch	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/config	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/coveragezone	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/crconfig	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/crconfigdsservers	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/crconfigpoller	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/crconfigregex	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/crstates	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/crstatespoller	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/fetch	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/httpsrvr	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/ipmap	[no test files]
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/nextcache	[no test files]
   ok  	github.com/apache/trafficcontrol/experimental/traffic_router_golang/quadtree	0.006s
   ?   	github.com/apache/trafficcontrol/experimental/traffic_router_golang/toutil	[no test files]
   ```
   
   The full package names do not display for you when you run the tests?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on pull request #6406: add go.mod and update README

Posted by GitBox <gi...@apache.org>.
asheikm commented on pull request #6406:
URL: https://github.com/apache/trafficcontrol/pull/6406#issuecomment-988152667


   @zrhoffman pls review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org