You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "icexelloss (via GitHub)" <gi...@apache.org> on 2023/03/10 15:05:35 UTC

[GitHub] [arrow] icexelloss opened a new issue, #34531: [C++] Address missed code review comments in ordered aggregation

icexelloss opened a new issue, #34531:
URL: https://github.com/apache/arrow/issues/34531

   ### Describe the enhancement requested
   
   A couple of review comments are missed about during https://github.com/apache/arrow/pull/34311
   
   Created this issue to track this minor follow up
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] icexelloss closed issue #34531: [C++] Address missed code review comments in ordered aggregation

Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss closed issue #34531: [C++] Address missed code review comments in ordered aggregation
URL: https://github.com/apache/arrow/issues/34531


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] icexelloss commented on issue #34531: [C++] Address missed code review comments in ordered aggregation

Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss commented on issue #34531:
URL: https://github.com/apache/arrow/issues/34531#issuecomment-1463939121

   e.g. https://github.com/apache/arrow/pull/34311/files/d68efd4c295d9fedfaf6ccc7804dfb591c4ecff2#r1128845883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] icexelloss commented on issue #34531: [C++] Address missed code review comments in ordered aggregation

Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss commented on issue #34531:
URL: https://github.com/apache/arrow/issues/34531#issuecomment-1463940858

   nvm - github diff issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org