You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Bolke de Bruin (JIRA)" <ji...@apache.org> on 2017/01/20 15:43:26 UTC

[jira] [Resolved] (AIRFLOW-739) test_pickle_info has an error message on travis while pickling

     [ https://issues.apache.org/jira/browse/AIRFLOW-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bolke de Bruin resolved AIRFLOW-739.
------------------------------------
    Resolution: Fixed

Issue resolved by pull request #1975
[https://github.com/apache/incubator-airflow/pull/1975]

> test_pickle_info has an error message on travis while pickling
> --------------------------------------------------------------
>
>                 Key: AIRFLOW-739
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-739
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Bolke de Bruin
>            Priority: Critical
>
> On Travis this test logs and error message but doesn't fail the test. This is because:
> {code}
>     @provide_session
>     def pickle_info(self, session=None):
>         d = {}
>         d['is_picklable'] = True
>         try:
>             dttm = datetime.now()
>             pickled = pickle.dumps(self)
>             d['pickle_len'] = len(pickled)
>             d['pickling_duration'] = "{}".format(datetime.now() - dttm)
>         except Exception as e:
>             logging.exception(e)
>             d['is_picklable'] = False
>             d['stacktrace'] = traceback.format_exc()
>         return d
> {code}
> Logs to error, while no propagation happens and the error is non fatal. Therefore it should log to debug instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)