You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey Varlamov (JIRA)" <ji...@apache.org> on 2007/04/03 11:11:32 UTC
[jira] Created: (HARMONY-3553) [drlvm][jit] get rid of jit helpers
IDs re-mapping
[drlvm][jit] get rid of jit helpers IDs re-mapping
--------------------------------------------------
Key: HARMONY-3553
URL: https://issues.apache.org/jira/browse/HARMONY-3553
Project: Harmony
Issue Type: Sub-task
Components: DRLVM
Reporter: Alexey Varlamov
Priority: Minor
Currently Jitrino does 1:1 remapping of VM_RT_SUPPORT enum to RuntimeHelperId enum. This is excessive and should be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3553) [drlvm][jit] get rid of jit helpers
IDs re-mapping
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov reassigned HARMONY-3553:
----------------------------------------
Assignee: Alexey Varlamov
> [drlvm][jit] get rid of jit helpers IDs re-mapping
> --------------------------------------------------
>
> Key: HARMONY-3553
> URL: https://issues.apache.org/jira/browse/HARMONY-3553
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Priority: Minor
>
> Currently Jitrino does 1:1 remapping of VM_RT_SUPPORT enum to RuntimeHelperId enum. This is excessive and should be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3553) [drlvm][jit] get rid of jit helpers
IDs re-mapping
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov resolved HARMONY-3553.
--------------------------------------
Resolution: Fixed
Fixed at revision: 584049
> [drlvm][jit] get rid of jit helpers IDs re-mapping
> --------------------------------------------------
>
> Key: HARMONY-3553
> URL: https://issues.apache.org/jira/browse/HARMONY-3553
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H3553.jit.diff, H3553.vm.diff, H3553.vm.diff
>
>
> Currently Jitrino does 1:1 remapping of VM_RT_SUPPORT enum to RuntimeHelperId enum. This is excessive and should be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3553) [drlvm][jit] get rid of jit helpers
IDs re-mapping
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov updated HARMONY-3553:
-------------------------------------
Patch Info: [Patch Available]
> [drlvm][jit] get rid of jit helpers IDs re-mapping
> --------------------------------------------------
>
> Key: HARMONY-3553
> URL: https://issues.apache.org/jira/browse/HARMONY-3553
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H3553.jit.diff, H3553.vm.diff
>
>
> Currently Jitrino does 1:1 remapping of VM_RT_SUPPORT enum to RuntimeHelperId enum. This is excessive and should be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3553) [drlvm][jit] get rid of jit helpers
IDs re-mapping
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov updated HARMONY-3553:
-------------------------------------
Attachment: H3553.vm.diff
> [drlvm][jit] get rid of jit helpers IDs re-mapping
> --------------------------------------------------
>
> Key: HARMONY-3553
> URL: https://issues.apache.org/jira/browse/HARMONY-3553
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H3553.vm.diff
>
>
> Currently Jitrino does 1:1 remapping of VM_RT_SUPPORT enum to RuntimeHelperId enum. This is excessive and should be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3553) [drlvm][jit] get rid of jit helpers
IDs re-mapping
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov updated HARMONY-3553:
-------------------------------------
Attachment: H3553.jit.diff
> [drlvm][jit] get rid of jit helpers IDs re-mapping
> --------------------------------------------------
>
> Key: HARMONY-3553
> URL: https://issues.apache.org/jira/browse/HARMONY-3553
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H3553.jit.diff, H3553.vm.diff
>
>
> Currently Jitrino does 1:1 remapping of VM_RT_SUPPORT enum to RuntimeHelperId enum. This is excessive and should be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3553) [drlvm][jit] get rid of jit
helpers IDs re-mapping
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534013 ]
Pavel Pervov commented on HARMONY-3553:
---------------------------------------
I'd suggest making vm_helper_get_interruptibility_kind and vm_helper_get_calling_convention a "check-bounds-and-index-in-the-array" kind of functions, integrating this information into helpers list. This will reduce readability of the code a lot. (I see, there is TODO in the patch, why not doing it right now?)
Also, comments from vm_helper_get_interruptibility_kind switch be better moved to the array, describing the helpers.
P.S. I wonder, why remapping existed in Jitrino first of all...
> [drlvm][jit] get rid of jit helpers IDs re-mapping
> --------------------------------------------------
>
> Key: HARMONY-3553
> URL: https://issues.apache.org/jira/browse/HARMONY-3553
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H3553.jit.diff, H3553.vm.diff
>
>
> Currently Jitrino does 1:1 remapping of VM_RT_SUPPORT enum to RuntimeHelperId enum. This is excessive and should be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3553) [drlvm][jit] get rid of jit
helpers IDs re-mapping
Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534011 ]
Pavel Afremov commented on HARMONY-3553:
----------------------------------------
VM part looks OK for me.
> [drlvm][jit] get rid of jit helpers IDs re-mapping
> --------------------------------------------------
>
> Key: HARMONY-3553
> URL: https://issues.apache.org/jira/browse/HARMONY-3553
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H3553.jit.diff, H3553.vm.diff
>
>
> Currently Jitrino does 1:1 remapping of VM_RT_SUPPORT enum to RuntimeHelperId enum. This is excessive and should be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3553) [drlvm][jit] get rid of jit
helpers IDs re-mapping
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533981 ]
Alexey Varlamov commented on HARMONY-3553:
------------------------------------------
Here is the suggested fix, it is separated to VM and JIT parts for review convenience. Jitrino's part is mostly autogenerated search&replace patch, and may be postponed if needed.
> [drlvm][jit] get rid of jit helpers IDs re-mapping
> --------------------------------------------------
>
> Key: HARMONY-3553
> URL: https://issues.apache.org/jira/browse/HARMONY-3553
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H3553.jit.diff, H3553.vm.diff
>
>
> Currently Jitrino does 1:1 remapping of VM_RT_SUPPORT enum to RuntimeHelperId enum. This is excessive and should be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3553) [drlvm][jit] get rid of jit helpers
IDs re-mapping
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov updated HARMONY-3553:
-------------------------------------
Attachment: H3553.vm.diff
Attached updated version of VM part, resolved issues mentioned above.
> [drlvm][jit] get rid of jit helpers IDs re-mapping
> --------------------------------------------------
>
> Key: HARMONY-3553
> URL: https://issues.apache.org/jira/browse/HARMONY-3553
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H3553.jit.diff, H3553.vm.diff, H3553.vm.diff
>
>
> Currently Jitrino does 1:1 remapping of VM_RT_SUPPORT enum to RuntimeHelperId enum. This is excessive and should be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.