You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/02/24 07:13:50 UTC
Review Request 57019: HiveView2.0: No notifications for successful
query which yields no output.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57019/
-----------------------------------------------------------
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20162
https://issues.apache.org/jira/browse/AMBARI-20162
Repository: ambari
Description
-------
- Added successful message for query
- Clean up visual explain code.
- Fix intermittent results null issue.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 16103b7
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js ff3832d
contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 273cd90
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs db1cea2
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs 370e3ef
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs 9bf2b2a
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs ef441b5
Diff: https://reviews.apache.org/r/57019/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 57019: HiveView2.0: No notifications for
successful query which yields no output.
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57019/#review166684
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On Feb. 24, 2017, 7:35 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57019/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 7:35 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20162
> https://issues.apache.org/jira/browse/AMBARI-20162
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Added successful message for query
> - Clean up visual explain code.
> - Fix intermittent results null issue.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 16103b7
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js ff3832d
> contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 273cd90
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs db1cea2
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs 370e3ef
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs 9bf2b2a
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs ef441b5
>
> Diff: https://reviews.apache.org/r/57019/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 57019: HiveView2.0: No notifications for
successful query which yields no output.
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57019/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 2:54 p.m.)
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20162
https://issues.apache.org/jira/browse/AMBARI-20162
Repository: ambari
Description
-------
- Added successful message for query
- Clean up visual explain code.
- Fix intermittent results null issue.
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 16103b7
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js ff3832d
contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 273cd90
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs c7e30f2
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs d859b04
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs 9bf2b2a
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs 5b7e566
Diff: https://reviews.apache.org/r/57019/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 57019: HiveView2.0: No notifications for
successful query which yields no output.
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57019/#review166656
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 24, 2017, 7:35 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57019/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 7:35 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20162
> https://issues.apache.org/jira/browse/AMBARI-20162
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Added successful message for query
> - Clean up visual explain code.
> - Fix intermittent results null issue.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 16103b7
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js ff3832d
> contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 273cd90
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs db1cea2
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs 370e3ef
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs 9bf2b2a
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs ef441b5
>
> Diff: https://reviews.apache.org/r/57019/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 57019: HiveView2.0: No notifications for
successful query which yields no output.
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57019/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 7:35 a.m.)
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20162
https://issues.apache.org/jira/browse/AMBARI-20162
Repository: ambari
Description
-------
- Added successful message for query
- Clean up visual explain code.
- Fix intermittent results null issue.
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 16103b7
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js ff3832d
contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 273cd90
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs db1cea2
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs 370e3ef
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs 9bf2b2a
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs ef441b5
Diff: https://reviews.apache.org/r/57019/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha