[jira] [Commented] (HDFS-8176) Provide information about the snapshots compared in audit log

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504533#comment-14504533 ] 

Hadoop QA commented on HDFS-8176:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12726157/HDFS-8176.1.patch
  against trunk revision d52de61.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.TestFileTruncate

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10328//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10328//console

This message is automatically generated.

> Provide information about the snapshots compared in audit log
> -------------------------------------------------------------
>
>                 Key: HDFS-8176
>                 URL: https://issues.apache.org/jira/browse/HDFS-8176
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: J.Andreina
>            Assignee: J.Andreina
>         Attachments: HDFS-8176.1.patch
>
>
> Provide information about the snapshots compared in audit log. 
> In current code value "null" is been passed. 
> {code}
> logAuditEvent(diffs != null, "computeSnapshotDiff", null, null, null);
> {code}
> {noformat}
> 2015-04-15 09:56:49,328 INFO FSNamesystem.audit: allowed=true   ugi=Rex (auth:SIMPLE)   ip=/XXXXXXXXX        cmd=computeSnapshotDiff src=null        dst=null        perm=null       proto=rpc
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)