You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erik Hatcher (JIRA)" <ji...@apache.org> on 2015/09/10 23:50:47 UTC

[jira] [Commented] (SOLR-8035) Move solr/webapp to solr/server/solr-webapp

    [ https://issues.apache.org/jira/browse/SOLR-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739673#comment-14739673 ] 

Erik Hatcher commented on SOLR-8035:
------------------------------------

Sorry, that's a large patch - but really just svn move plus some build/ignore tweaks.  Here's just the build changes:

{code}
Index: solr/build.xml
===================================================================
--- solr/build.xml	(revision 1702327)
+++ solr/build.xml	(working copy)
@@ -316,7 +316,7 @@
     <license-check-macro dir="${basedir}" licensedir="${common-solr.dir}/licenses">
       <additional-excludes>
         <exclude name="example/exampledocs/post.jar" />
-        <exclude name="server/solr-webapp/**" />
+        <!--<exclude name="server/solr-webapp/**" />-->
         <exclude name="package/**"/>
       </additional-excludes>
       <additional-filters>
@@ -376,7 +376,7 @@
         <include name="start.jar" />
         <include name="logs/*" />
         <include name="webapps" />
-        <include name="solr-webapp/**/*" />
+        <!--<include name="solr-webapp/**/*" />-->
         <exclude name="**/.gitignore" />
       </fileset>      
     </delete>
Index: solr/webapp/build.xml
===================================================================
--- solr/webapp/build.xml	(revision 1702327)
+++ solr/webapp/build.xml	(working copy)
@@ -40,9 +40,9 @@
           description="Creates the Webapp folder for distribution."
           depends="dist-core, dist-solrj, lucene-jars-to-solr">
     <ant dir="${common-solr.dir}" inheritall="false" target="contribs-add-to-webapp"/>
-    <mkdir dir="${server.dir}/solr-webapp/webapp"/>
+    <!--<mkdir dir="${server.dir}/solr-webapp/webapp"/>-->
     <copy todir="${server.dir}/solr-webapp/webapp">
-      <fileset dir="web" excludes="${exclude.from.webapp}"/>
+      <!--<fileset dir="web" excludes="${exclude.from.webapp}"/>-->
       <fileset dir="${dest}/web" excludes="${exclude.from.war}"/> <!-- contribs' additions -->
     </copy>
     <mkdir dir="${server.dir}/solr-webapp/webapp/WEB-INF/lib"/>
{code}

> Move solr/webapp to solr/server/solr-webapp
> -------------------------------------------
>
>                 Key: SOLR-8035
>                 URL: https://issues.apache.org/jira/browse/SOLR-8035
>             Project: Solr
>          Issue Type: Bug
>          Components: UI
>            Reporter: Erik Hatcher
>            Assignee: Erik Hatcher
>            Priority: Critical
>             Fix For: Trunk, 5.4
>
>         Attachments: SOLR-8035.patch
>
>
> Let's move solr/webapp *source* files to their final actual distro destination.  This facilitates folks editing the UI in real-time (save change, refresh in browser) rather than having to "stop, ant server, restart" to see a change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org