You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@qpid.apache.org by Oleksandr Rudyy <or...@gmail.com> on 2018/02/27 14:57:43 UTC

[VOTE] Release Apache Qpid Broker-J 7.0.2

Hi all,

I built a release candidate for a Qpid Broker-J 7.0.2.
Please give it a test out and vote accordingly.

The source and binary archives can be grabbed from:
https://dist.apache.org/repos/dist/dev/qpid/broker-j/7.0.2-rc1

The maven artifacts are also staged for now at:
https://repository.apache.org/content/repositories/orgapacheqpid-1132

The JIRAs currently assigned are:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520&version=12342782

Regards,
Alex

P.S. For testing of maven broker staging repo artifacts, please add into to
your poms the staging repo as below:

  <repositories>
    <repository>
      <id>staging</id>
      <url>
https://repository.apache.org/content/repositories/orgapacheqpid-1132</url>
    </repository>
  </repositories>


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org

Re: [VOTE] Release Apache Qpid Broker-J 7.0.2

Posted by Robbie Gemmell <ro...@gmail.com>.
On 27 February 2018 at 14:57, Oleksandr Rudyy <or...@gmail.com> wrote:
> Hi all,
>
> I built a release candidate for a Qpid Broker-J 7.0.2.
> Please give it a test out and vote accordingly.
>
> The source and binary archives can be grabbed from:
> https://dist.apache.org/repos/dist/dev/qpid/broker-j/7.0.2-rc1
>
> The maven artifacts are also staged for now at:
> https://repository.apache.org/content/repositories/orgapacheqpid-1132
>
> The JIRAs currently assigned are:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520&version=12342782
>
> Regards,
> Alex
>
> P.S. For testing of maven broker staging repo artifacts, please add into to
> your poms the staging repo as below:
>
>   <repositories>
>     <repository>
>       <id>staging</id>
>       <url>
> https://repository.apache.org/content/repositories/orgapacheqpid-1132</url>
>     </repository>
>   </repositories>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org

+1

I checked things out as follows:
- Verified the signatures and checksums.
- Used "mvn apache-rat:check" to verify the headers in source release.
- Checked for LICENCE and NOTICE files being present in each archive.
- Ran the source release build and unit tests under the default profile.

Robbie

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: [VOTE] Release Apache Qpid Broker-J 7.0.2

Posted by Rob Godfrey <ro...@gmail.com>.
I raised QPID-8113 for this issue and pushed a simple fix.

I'll raise a separate JIRA covering the fact that the error handling here
is poor, an unknown filter should really cause an attach{source: null},
followed by an immediate detach rather than closing the connection - and
certainly not a decode error.

-- Rob

On 28 February 2018 at 14:41, Gordon Sim <gs...@redhat.com> wrote:

> On 28/02/18 13:20, Rob Godfrey wrote:
>
>> I would assume this is not a new error
>>
>
> Agreed, was noting in passing.
>
> ... from the looks of things this is
>> the Broker not supporting the "apache.org:selector-filter:string" filter
>> type, and choking on the fact in a less than graceful way.
>> Looking at the Broker-J code in
>> org.apache.qpid.server.protocol.v1_0.type.messaging.codec.JM
>> SSelectorFilterConstructor
>> it appears that the symbolic descriptor is not defined correctly there
>> while the ulong descriptor is correct (which is why, for instance, the JMS
>> client works).
>>
>
> Yes, a javascript example I ran also used numeric and passed.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
>
>

Re: [VOTE] Release Apache Qpid Broker-J 7.0.2

Posted by Gordon Sim <gs...@redhat.com>.
On 28/02/18 13:20, Rob Godfrey wrote:
> I would assume this is not a new error

Agreed, was noting in passing.

>... from the looks of things this is
> the Broker not supporting the "apache.org:selector-filter:string" filter
> type, and choking on the fact in a less than graceful way.
> Looking at the Broker-J code in
> org.apache.qpid.server.protocol.v1_0.type.messaging.codec.JMSSelectorFilterConstructor
> it appears that the symbolic descriptor is not defined correctly there
> while the ulong descriptor is correct (which is why, for instance, the JMS
> client works).

Yes, a javascript example I ran also used numeric and passed.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: [VOTE] Release Apache Qpid Broker-J 7.0.2

Posted by Rob Godfrey <ro...@gmail.com>.
On 28 February 2018 at 12:17, Gordon Sim <gs...@redhat.com> wrote:

> On 27/02/18 14:57, Oleksandr Rudyy wrote:
>
>> Hi all,
>>
>> I built a release candidate for a Qpid Broker-J 7.0.2.
>> Please give it a test out and vote accordingly.
>>
>
> +1
>
> Verified hashes and signatures, built from source including tests, ran
> python examples against it, ran qpid::messaging against it, ran some other
> AMQP 1.0 examples against it.
>
> One thing to note though is that the selected_recv.py python example fails
> with the broker returning an amqp:decode-error: Expected key type is
> 'Filter' but got 'DescribedType'. I don't understand that error but the
> protocol trace from proton is below. A variation of this in javascript
> passes, where the key is jms-selector instead of just selector and the
> descriptor is numeric rather than symbolic (not sure if that is the issue?).
>
> $ PN_TRACE_FRM=1 ./selected_recv.py [0x555941994670]:  -> SASL
>> [0x555941994670]:  <- SASL
>> [0x555941994670]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=@PN_SY
>> MBOL[:ANONYMOUS]]
>> [0x555941994670]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS,
>> initial-response=b"anonymous@localhost.localdomain"]
>> [0x555941994670]:0 <- @sasl-outcome(68) [code=0]
>> [0x555941994670]:  -> AMQP
>> [0x555941994670]:0 -> @open(16) [container-id="99957991-87b0-4e80-95ef-d346f1e42612",
>> hostname="localhost", channel-max=32767]
>> [0x555941994670]:0 -> @begin(17) [next-outgoing-id=0,
>> incoming-window=2147483647, outgoing-window=2147483647]
>> [0x555941994670]:0 -> @attach(18) [name="99957991-87b0-4e80-95ef-d346f1e42612-examples",
>> handle=0, role=true, snd-settle-mode=2, rcv-settle-mode=0,
>> source=@source(40) [address="examples", durable=0, timeout=0,
>> dynamic=false, filter={:selector=@:"apache.org:selector-filter:string"
>> "colour = 'green'"}], target=@target(41) [durable=0, timeout=0,
>> dynamic=false], initial-delivery-count=0, max-message-size=0]
>> [0x555941994670]:0 -> @flow(19) [incoming-window=2147483647,
>> next-outgoing-id=0, outgoing-window=2147483647, handle=0, delivery-count=0,
>> link-credit=10, drain=false]
>> [0x555941994670]:  <- AMQP
>> [0x555941994670]:0 <- @open(16) [container-id="087cb095-8666-4473-bc70-f60f846f5ef7",
>> max-frame-size=0, channel-max=0, idle-time-out=0,
>> offered-capabilities=@PN_SYMBOL[:"ANONYMOUS-RELAY", :"SHARED-SUBS",
>> :"sole-connection-for-container"], properties={:product="qpid",
>> :version="7.0.2", :"qpid.build"="Unversioned directory",
>> :"qpid.instance_name"="Broker", :"qpid.virtualhost_properties_
>> supported"="true"}]
>> [0x555941994670]:0 <- @close(24) [error=@error(29)
>> [condition=:"amqp:decode-error", description="Expected key type is
>> 'Filter' but got 'DescribedType'"]]
>> [0x555941994670]:  <- EOS
>> [0x555941994670]:0 -> @close(24) []
>> [0x555941994670]:  -> EOS
>>
>
>
I would assume this is not a new error... from the looks of things this is
the Broker not supporting the "apache.org:selector-filter:string" filter
type, and choking on the fact in a less than graceful way.
Looking at the Broker-J code in
org.apache.qpid.server.protocol.v1_0.type.messaging.codec.JMSSelectorFilterConstructor
it appears that the symbolic descriptor is not defined correctly there
while the ulong descriptor is correct (which is why, for instance, the JMS
client works).

-- Rob



>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
>
>

Re: [VOTE] Release Apache Qpid Broker-J 7.0.2

Posted by Gordon Sim <gs...@redhat.com>.
On 27/02/18 14:57, Oleksandr Rudyy wrote:
> Hi all,
> 
> I built a release candidate for a Qpid Broker-J 7.0.2.
> Please give it a test out and vote accordingly.

+1

Verified hashes and signatures, built from source including tests, ran 
python examples against it, ran qpid::messaging against it, ran some 
other AMQP 1.0 examples against it.

One thing to note though is that the selected_recv.py python example 
fails with the broker returning an amqp:decode-error: Expected key type 
is 'Filter' but got 'DescribedType'. I don't understand that error but 
the protocol trace from proton is below. A variation of this in 
javascript passes, where the key is jms-selector instead of just 
selector and the descriptor is numeric rather than symbolic (not sure if 
that is the issue?).

> $ PN_TRACE_FRM=1 ./selected_recv.py 
> [0x555941994670]:  -> SASL
> [0x555941994670]:  <- SASL
> [0x555941994670]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> [0x555941994670]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"anonymous@localhost.localdomain"]
> [0x555941994670]:0 <- @sasl-outcome(68) [code=0]
> [0x555941994670]:  -> AMQP
> [0x555941994670]:0 -> @open(16) [container-id="99957991-87b0-4e80-95ef-d346f1e42612", hostname="localhost", channel-max=32767]
> [0x555941994670]:0 -> @begin(17) [next-outgoing-id=0, incoming-window=2147483647, outgoing-window=2147483647]
> [0x555941994670]:0 -> @attach(18) [name="99957991-87b0-4e80-95ef-d346f1e42612-examples", handle=0, role=true, snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) [address="examples", durable=0, timeout=0, dynamic=false, filter={:selector=@:"apache.org:selector-filter:string" "colour = 'green'"}], target=@target(41) [durable=0, timeout=0, dynamic=false], initial-delivery-count=0, max-message-size=0]
> [0x555941994670]:0 -> @flow(19) [incoming-window=2147483647, next-outgoing-id=0, outgoing-window=2147483647, handle=0, delivery-count=0, link-credit=10, drain=false]
> [0x555941994670]:  <- AMQP
> [0x555941994670]:0 <- @open(16) [container-id="087cb095-8666-4473-bc70-f60f846f5ef7", max-frame-size=0, channel-max=0, idle-time-out=0, offered-capabilities=@PN_SYMBOL[:"ANONYMOUS-RELAY", :"SHARED-SUBS", :"sole-connection-for-container"], properties={:product="qpid", :version="7.0.2", :"qpid.build"="Unversioned directory", :"qpid.instance_name"="Broker", :"qpid.virtualhost_properties_supported"="true"}]
> [0x555941994670]:0 <- @close(24) [error=@error(29) [condition=:"amqp:decode-error", description="Expected key type is 'Filter' but got 'DescribedType'"]]
> [0x555941994670]:  <- EOS
> [0x555941994670]:0 -> @close(24) []
> [0x555941994670]:  -> EOS


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: [VOTE] Release Apache Qpid Broker-J 7.0.2

Posted by Rob Godfrey <ro...@gmail.com>.
+1

built for source and ran java-mms tests for 0-9-1 and 1.0
started broker and kicked tires using management console
sent / received messages using JMS & Python (AMQP 1.0)

On 28 February 2018 at 11:39, Oleksandr Rudyy <or...@gmail.com> wrote:

> +1
>
> I performed the following testing:
>
> * built from source bundle and ran tests using  java-mms.10 profile
> * verified signatures and checksums
> * started broker
> * using web management console
> ** added test queue
> ** added node auto-creation policy
> ** created queue query and exported the results in CSV format
> * ran HelloWorld example from Qpid JMS Client and verified that queue
> was created by node auto-creation policy
>
>
> On 27 February 2018 at 14:57, Oleksandr Rudyy <or...@gmail.com> wrote:
> > Hi all,
> >
> > I built a release candidate for a Qpid Broker-J 7.0.2.
> > Please give it a test out and vote accordingly.
> >
> > The source and binary archives can be grabbed from:
> > https://dist.apache.org/repos/dist/dev/qpid/broker-j/7.0.2-rc1
> >
> > The maven artifacts are also staged for now at:
> > https://repository.apache.org/content/repositories/orgapacheqpid-1132
> >
> > The JIRAs currently assigned are:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12310520&version=12342782
> >
> > Regards,
> > Alex
> >
> > P.S. For testing of maven broker staging repo artifacts, please add into
> to
> > your poms the staging repo as below:
> >
> >   <repositories>
> >     <repository>
> >       <id>staging</id>
> >
> > <url>https://repository.apache.org/content/repositories/orgapacheqpid-
> 1132</url>
> >     </repository>
> >   </repositories>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> > For additional commands, e-mail: users-help@qpid.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
>
>

Re: [VOTE] Release Apache Qpid Broker-J 7.0.2

Posted by Oleksandr Rudyy <or...@gmail.com>.
+1

I performed the following testing:

* built from source bundle and ran tests using  java-mms.10 profile
* verified signatures and checksums
* started broker
* using web management console
** added test queue
** added node auto-creation policy
** created queue query and exported the results in CSV format
* ran HelloWorld example from Qpid JMS Client and verified that queue
was created by node auto-creation policy


On 27 February 2018 at 14:57, Oleksandr Rudyy <or...@gmail.com> wrote:
> Hi all,
>
> I built a release candidate for a Qpid Broker-J 7.0.2.
> Please give it a test out and vote accordingly.
>
> The source and binary archives can be grabbed from:
> https://dist.apache.org/repos/dist/dev/qpid/broker-j/7.0.2-rc1
>
> The maven artifacts are also staged for now at:
> https://repository.apache.org/content/repositories/orgapacheqpid-1132
>
> The JIRAs currently assigned are:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520&version=12342782
>
> Regards,
> Alex
>
> P.S. For testing of maven broker staging repo artifacts, please add into to
> your poms the staging repo as below:
>
>   <repositories>
>     <repository>
>       <id>staging</id>
>
> <url>https://repository.apache.org/content/repositories/orgapacheqpid-1132</url>
>     </repository>
>   </repositories>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: [VOTE] Release Apache Qpid Broker-J 7.0.2

Posted by Keith W <ke...@gmail.com>.
+1.

My testing was:

1) Verified the md5/sha checksums on all distribution artefacts
2) Verified signatures on all the distribution artefacts
3) Ran apache RAT
4) Built/ran test profile mms/bdb 0-9/1.0 from source bundle (Qpid JMS
Client 0.26.0/0.29.0)
5) Generally kicked the tyres within the Web Management Console using
Broker from the tar,gz bundle
6) Spun up an embedded Broker-J using the staged maven artefacts.


On 27 February 2018 at 14:57, Oleksandr Rudyy <or...@gmail.com> wrote:
> Hi all,
>
> I built a release candidate for a Qpid Broker-J 7.0.2.
> Please give it a test out and vote accordingly.
>
> The source and binary archives can be grabbed from:
> https://dist.apache.org/repos/dist/dev/qpid/broker-j/7.0.2-rc1
>
> The maven artifacts are also staged for now at:
> https://repository.apache.org/content/repositories/orgapacheqpid-1132
>
> The JIRAs currently assigned are:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520&version=12342782
>
> Regards,
> Alex
>
> P.S. For testing of maven broker staging repo artifacts, please add into to
> your poms the staging repo as below:
>
>   <repositories>
>     <repository>
>       <id>staging</id>
>       <url>
> https://repository.apache.org/content/repositories/orgapacheqpid-1132</url>
>     </repository>
>   </repositories>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org