[jira] [Commented] (MIME4J-270) MultipartBuilder creates message with null subtype

["Dmitry Katsubo (JIRA)" <mi...@james.apache.org>]

    [ https://issues.apache.org/jira/browse/MIME4J-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477379#comment-16477379 ] 

Dmitry Katsubo commented on MIME4J-270:
---------------------------------------

Hi Tellier,

I have attached [^james-mime4j.patch] (let me know if I can provide that change as pull request – I didn't find the way how).

While working with the project I has located few other minor sloppy places – should I create a ticket per each one?

> MultipartBuilder creates message with null subtype
> --------------------------------------------------
>
>                 Key: MIME4J-270
>                 URL: https://issues.apache.org/jira/browse/MIME4J-270
>             Project: James Mime4j
>          Issue Type: Improvement
>          Components: dom
>    Affects Versions: 0.8.1
>            Reporter: Dmitry Katsubo
>            Priority: Minor
>         Attachments: james-mime4j.patch
>
>
> JavaDoc of [{{MultipartBuilder#getSubType()}}|https://github.com/apache/james-mime4j/blob/6c31bd1e8f8b97cc432bbf9580e7383f00de1506/dom/src/main/java/org/apache/james/mime4j/message/MultipartBuilder.java#L75] reads:
> {quote}Gets the multipart sub-type. E.g. {{alternative}} (the default) or {{parallel}}. See RFC 2045 for common sub-types and their meaning.
> {quote}
> however builder creates multipart with {{null}} subtype:
> {code:java}
> Multipart multipart = MultipartBuilder.create().build();
> new DefaultMessageWriter().writeMessage(multipart, System.out);
> {code}
> outputs:
> {code:java}
> MIME-Version: 1.0
> Content-Type: multipart/null; boundary="-=Part.0.c3f59e98561a68df.16251ed82a4.feee6e1cf64afde8=-"
> {code}
> Expected that builder is initialized with some default subtype.
>  More over subtypes are listed in RFC *2046* (not in 2045):
>  * [Alternative Subtype|https://tools.ietf.org/html/rfc2046#section-5.1.4]
>  * [Parallel Subtype|https://tools.ietf.org/html/rfc2046#section-5.1.6]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)