[GitHub] [solr] epugh commented on a diff in pull request #1808: SOLR-16800: Move towards using the root of Solr as the -solrUrl in the CLI.

["epugh (via GitHub)" <gi...@apache.org>]

epugh commented on code in PR #1808:
URL: https://github.com/apache/solr/pull/1808#discussion_r1285218105


##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -383,6 +383,11 @@ public static boolean exceptionIsAuthRelated(Exception exc) {
   }
 
   public static SolrClient getSolrClient(String solrUrl) {
+    // today we require all urls to end in /solr, however in the future we will need to support the
+    // /api url end point instead.
+    if (!solrUrl.endsWith(("/solr"))) {

Review Comment:
   okay, I've pulled in `main` that has the now hardcoded hostContext...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org