[jira] [Resolved] (THRIFT-2976) nodejs: xhr and websocket support for browserify

["Randy Abernethy (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Randy Abernethy resolved THRIFT-2976.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.9.3
         Assignee: Randy Abernethy

Committed. Thanks for the patch Andrew!

> nodejs: xhr and websocket support for browserify
> ------------------------------------------------
>
>                 Key: THRIFT-2976
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2976
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>         Environment: Trusty64 Vagrant box
>            Reporter: Andrew de Andrade
>            Assignee: Randy Abernethy
>             Fix For: 0.9.3
>
>         Attachments: 0001-nodejs-xhr-and-websocket-browser-support.patch
>
>
> The attached patch adds support for XHR connections and WebSocket connections in the browser. Currently there are only tests for XHR since phantomjs 1.x.x does not fully support the websockets protocol. Once phantom 2.x.x is released a test for websockets will be added. Currently only TJSONProtocol and TBufferedTransport are supported. More work needs to be done to get other protocols and transports to work.
> To make browser tests work, all tests were converted to substack/tape (which is a TAP testing harness that works both on the server and in the browser). This has the side effect of making the tests way more readable.
> Depends on the patches on these issues applied in this order:
> THRIFT-2932 - Node.js Thrift connection libraries throw Exceptions into event emitter
> THRIFT-2969 - nodejs: DRY up library tests
> THRIFT-2964 - nodejs: move protocols and transports into separate files



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)