You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/03/18 01:56:22 UTC

Review Request 57747: Fixed invocations of 'executorEnvironment' in the tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57747/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.


Bugs: MESOS-6999
    https://issues.apache.org/jira/browse/MESOS-6999


Repository: mesos


Description
-------

This patch updates invocations of `executorEnvironment` in the tests
to use the function's new signature, which accepts a secret generator.


Diffs
-----

  src/tests/containerizer/mesos_containerizer_tests.cpp ec9f354c8cb6735f319b7dbea2465a31f3a8d64d 
  src/tests/hook_tests.cpp 71e619c139c171729126c15c5250cec53d86d83c 


Diff: https://reviews.apache.org/r/57747/diff/1/


Testing
-------

Testing details can be found at the end of this patch chain.


Thanks,

Greg Mann

Re: Review Request 57747: Fixed invocations of 'executorEnvironment' in the tests.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57747/
-----------------------------------------------------------

(Updated March 22, 2017, 2:43 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.


Bugs: MESOS-6999
    https://issues.apache.org/jira/browse/MESOS-6999


Repository: mesos


Description (updated)
-------

This patch updates invocations of `executorEnvironment` in the tests
to use the function's new signature, which accepts an authentication
token.


Diffs (updated)
-----

  src/tests/containerizer/mesos_containerizer_tests.cpp ec9f354c8cb6735f319b7dbea2465a31f3a8d64d 
  src/tests/hook_tests.cpp 71e619c139c171729126c15c5250cec53d86d83c 


Diff: https://reviews.apache.org/r/57747/diff/3/

Changes: https://reviews.apache.org/r/57747/diff/2-3/


Testing
-------

Testing details can be found at the end of this patch chain.


Thanks,

Greg Mann

Re: Review Request 57747: Fixed invocations of 'executorEnvironment' in the tests.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57747/
-----------------------------------------------------------

(Updated March 22, 2017, 1:43 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.


Bugs: MESOS-6999
    https://issues.apache.org/jira/browse/MESOS-6999


Repository: mesos


Description
-------

This patch updates invocations of `executorEnvironment` in the tests
to use the function's new signature, which accepts a secret generator.


Diffs
-----

  src/tests/containerizer/mesos_containerizer_tests.cpp ec9f354c8cb6735f319b7dbea2465a31f3a8d64d 
  src/tests/hook_tests.cpp 71e619c139c171729126c15c5250cec53d86d83c 


Diff: https://reviews.apache.org/r/57747/diff/2/


Testing
-------

Testing details can be found at the end of this patch chain.


Thanks,

Greg Mann

Re: Review Request 57747: Fixed invocations of 'executorEnvironment' in the tests.

Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57747/#review169606
-----------------------------------------------------------


Ship it!




Ship It!

- Anand Mazumdar


On March 21, 2017, 2:51 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57747/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 2:51 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates invocations of `executorEnvironment` in the tests
> to use the function's new signature, which accepts a secret generator.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp ec9f354c8cb6735f319b7dbea2465a31f3a8d64d 
>   src/tests/hook_tests.cpp 71e619c139c171729126c15c5250cec53d86d83c 
> 
> 
> Diff: https://reviews.apache.org/r/57747/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this patch chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 57747: Fixed invocations of 'executorEnvironment' in the tests.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57747/
-----------------------------------------------------------

(Updated March 21, 2017, 2:51 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.


Bugs: MESOS-6999
    https://issues.apache.org/jira/browse/MESOS-6999


Repository: mesos


Description
-------

This patch updates invocations of `executorEnvironment` in the tests
to use the function's new signature, which accepts a secret generator.


Diffs (updated)
-----

  src/tests/containerizer/mesos_containerizer_tests.cpp ec9f354c8cb6735f319b7dbea2465a31f3a8d64d 
  src/tests/hook_tests.cpp 71e619c139c171729126c15c5250cec53d86d83c 


Diff: https://reviews.apache.org/r/57747/diff/2/

Changes: https://reviews.apache.org/r/57747/diff/1-2/


Testing
-------

Testing details can be found at the end of this patch chain.


Thanks,

Greg Mann