[GitHub] [spark] amaliujia commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect

["amaliujia (via GitHub)" <gi...@apache.org>]

amaliujia commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1151086910


##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -226,6 +226,17 @@ def test_error_handling(self):
         with self.assertRaises(AnalysisException):
             df.collect()
 
+    def test_error_stack_trace(self):
+        self.connect.conf.set("spark.sql.pyspark.jvmStacktrace.enabled", "true")
+        with self.assertRaises(AnalysisException) as e:
+            self.connect.sql("select x").collect()
+        self.assertTrue("JVM stacktrace" in e.exception.message)

Review Comment:
   Can we match the true AnalysisException error messages? It should be something like `column_not_resolved`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org