You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2024/02/26 04:12:22 UTC

[PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

yiguolei opened a new pull request, #31394:
URL: https://github.com/apache/doris/pull/31394

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31394:
URL: https://github.com/apache/doris/pull/31394#issuecomment-1963455075

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31394:
URL: https://github.com/apache/doris/pull/31394#issuecomment-1963490590

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41759 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 6245367a1abef3c030575192e3a6d81d124449c6, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	18232	5313	5172	5172
   q2	2872	144	139	139
   q3	11676	1041	1015	1015
   q4	5307	999	1034	999
   q5	8239	3210	3224	3210
   q6	198	137	131	131
   q7	1274	782	767	767
   q8	9395	2123	2080	2080
   q9	7529	6680	6596	6596
   q10	8310	2639	2655	2639
   q11	422	224	216	216
   q12	777	327	333	327
   q13	17942	3626	3645	3626
   q14	289	260	259	259
   q15	593	513	493	493
   q16	486	414	404	404
   q17	942	907	901	901
   q18	7210	6689	6670	6670
   q19	1561	1509	1493	1493
   q20	482	275	267	267
   q21	6293	4014	4012	4012
   q22	520	354	343	343
   Total cold run time: 110549 ms
   Total hot run time: 41759 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4911	4886	4857	4857
   q2	297	183	187	183
   q3	3604	3574	3579	3574
   q4	2551	2557	2511	2511
   q5	5776	5748	5768	5748
   q6	211	126	124	124
   q7	2241	1653	1700	1653
   q8	3068	3132	3168	3132
   q9	8726	8759	8664	8664
   q10	4204	4244	4249	4244
   q11	508	382	368	368
   q12	772	536	543	536
   q13	4197	3423	3405	3405
   q14	265	240	238	238
   q15	593	513	508	508
   q16	467	448	443	443
   q17	1674	1602	1607	1602
   q18	8347	7630	7611	7611
   q19	1646	1649	1646	1646
   q20	2089	1833	1828	1828
   q21	6641	6201	6178	6178
   q22	564	499	525	499
   Total cold run time: 63352 ms
   Total hot run time: 59552 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31394:
URL: https://github.com/apache/doris/pull/31394#issuecomment-1963292713

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31394:
URL: https://github.com/apache/doris/pull/31394#issuecomment-1963507061

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 176156 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 6245367a1abef3c030575192e3a6d81d124449c6, data reload: false
   
   query1	924	344	353	344
   query2	6518	1747	1675	1675
   query3	6712	204	196	196
   query4	23133	20976	21062	20976
   query5	4201	373	369	369
   query6	270	168	172	168
   query7	4600	290	294	290
   query8	251	194	209	194
   query9	8438	2850	2840	2840
   query10	414	231	235	231
   query11	15006	14637	14436	14436
   query12	139	82	81	81
   query13	1699	410	428	410
   query14	9095	7645	7672	7645
   query15	213	191	190	190
   query16	7532	261	250	250
   query17	1400	538	518	518
   query18	1945	277	262	262
   query19	193	146	150	146
   query20	89	79	87	79
   query21	186	128	119	119
   query22	5000	4785	4730	4730
   query23	32435	31502	31443	31443
   query24	12731	3346	3448	3346
   query25	651	362	366	362
   query26	1859	155	164	155
   query27	3039	309	316	309
   query28	6671	1827	1796	1796
   query29	1115	631	623	623
   query30	280	141	142	141
   query31	935	757	769	757
   query32	98	62	54	54
   query33	730	223	231	223
   query34	1082	483	506	483
   query35	926	803	826	803
   query36	1000	908	883	883
   query37	144	64	62	62
   query38	3326	3166	3170	3166
   query39	1381	1342	1301	1301
   query40	287	102	107	102
   query41	38	37	36	36
   query42	106	98	101	98
   query43	471	439	438	438
   query44	1082	692	717	692
   query45	194	189	176	176
   query46	1049	784	789	784
   query47	1645	1578	1481	1481
   query48	440	351	345	345
   query49	1200	318	314	314
   query50	770	376	378	376
   query51	4431	4315	4322	4315
   query52	110	98	94	94
   query53	395	298	304	298
   query54	303	220	230	220
   query55	86	84	77	77
   query56	229	198	219	198
   query57	1062	949	936	936
   query58	204	192	199	192
   query59	2191	2119	2113	2113
   query60	238	215	223	215
   query61	91	83	81	81
   query62	602	369	372	369
   query63	355	304	306	304
   query64	6401	3084	3129	3084
   query65	3310	3237	3270	3237
   query66	1355	324	323	323
   query67	14727	14320	14341	14320
   query68	5171	550	572	550
   query69	519	357	357	357
   query70	1266	1215	1166	1166
   query71	407	256	275	256
   query72	6311	2790	2596	2596
   query73	703	313	310	310
   query74	6836	6420	6501	6420
   query75	3246	2565	2551	2551
   query76	3295	1111	1191	1111
   query77	355	239	242	239
   query78	9442	8808	8719	8719
   query79	980	517	504	504
   query80	517	363	342	342
   query81	436	207	200	200
   query82	163	82	84	82
   query83	144	121	118	118
   query84	227	79	79	79
   query85	1034	353	343	343
   query86	304	296	304	296
   query87	3434	3313	3237	3237
   query88	2749	2323	2288	2288
   query89	454	353	367	353
   query90	1978	171	166	166
   query91	154	131	130	130
   query92	55	47	52	47
   query93	1035	511	491	491
   query94	1172	180	175	175
   query95	442	338	347	338
   query96	574	264	267	264
   query97	4454	4270	4250	4250
   query98	226	202	198	198
   query99	1039	723	706	706
   Total cold run time: 268855 ms
   Total hot run time: 176156 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #31394:
URL: https://github.com/apache/doris/pull/31394#issuecomment-1963453930

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31394:
URL: https://github.com/apache/doris/pull/31394#issuecomment-1963497407

   TeamCity be ut coverage result:
    Function Coverage: 35.73% (8548/23924) 
    Line Coverage: 27.53% (69355/251939)
    Region Coverage: 26.68% (35976/134826)
    Branch Coverage: 23.48% (18385/78294)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/6245367a1abef3c030575192e3a6d81d124449c6_6245367a1abef3c030575192e3a6d81d124449c6/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31394:
URL: https://github.com/apache/doris/pull/31394#issuecomment-1963515176

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.6 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 6245367a1abef3c030575192e3a6d81d124449c6, data reload: false
   
   query1	0.03	0.02	0.02
   query2	0.06	0.02	0.02
   query3	0.22	0.07	0.08
   query4	1.65	0.10	0.09
   query5	0.48	0.48	0.48
   query6	1.39	0.60	0.60
   query7	0.02	0.01	0.02
   query8	0.03	0.02	0.02
   query9	0.52	0.43	0.44
   query10	0.47	0.48	0.48
   query11	0.12	0.09	0.09
   query12	0.13	0.10	0.09
   query13	0.59	0.59	0.58
   query14	0.77	0.80	0.79
   query15	0.84	0.79	0.80
   query16	0.32	0.34	0.34
   query17	0.94	0.91	0.88
   query18	0.17	0.17	0.18
   query19	1.80	1.67	1.65
   query20	0.02	0.01	0.02
   query21	15.42	0.62	0.58
   query22	2.98	3.62	2.03
   query23	17.60	1.01	1.09
   query24	2.04	0.78	0.31
   query25	0.64	0.07	0.06
   query26	0.15	0.14	0.14
   query27	0.07	0.05	0.05
   query28	11.80	0.80	0.82
   query29	12.50	3.37	3.46
   query30	0.53	0.51	0.49
   query31	2.78	0.35	0.36
   query32	3.36	0.47	0.47
   query33	3.15	3.13	3.15
   query34	15.35	4.53	4.49
   query35	4.52	4.50	4.52
   query36	1.06	0.93	0.96
   query37	0.06	0.06	0.05
   query38	0.04	0.03	0.03
   query39	0.02	0.02	0.02
   query40	0.16	0.14	0.15
   query41	0.08	0.02	0.01
   query42	0.03	0.01	0.02
   query43	0.03	0.02	0.02
   Total cold run time: 104.94 s
   Total hot run time: 30.6 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31394:
URL: https://github.com/apache/doris/pull/31394#issuecomment-1963285840

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31394:
URL: https://github.com/apache/doris/pull/31394#issuecomment-1963455040

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31394:
URL: https://github.com/apache/doris/pull/31394#issuecomment-1963521612

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 6245367a1abef3c030575192e3a6d81d124449c6 with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       17.3 seconds inserted 10000000 Rows, about 578K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhancement](pipelinex) limit add_child to and dependency to avoid error [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #31394:
URL: https://github.com/apache/doris/pull/31394


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org