[GitHub] spark pull request #16788: [SPARK-16742] Kerberos impersonation support

[mridulm <gi...@git.apache.org>]

Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16788#discussion_r105319198
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -151,9 +152,13 @@ object SparkSubmit extends CommandLineUtils {
         val (childArgs, childClasspath, sysProps, childMainClass) = prepareSubmitEnvironment(args)
     
         def doRunMain(): Unit = {
    +      if (args.principal != null && args.keytab!= null) {
    +        KerberosUser.securize(args.principal, args.keytab)
    --- End diff --
    
    This will cause multiple UGI.loginUserFromKeytab (in yarn case it happens in SparkSubmit.prepareSubmitEnvironment) - which causes various issues.
    In an application, there must be only one call to UGI.loginUserFromKeytab; if more than one, random things fail (dfs client, metastore, etc) due to the way the loginUser is cached/used and hadoop ipc renews unfortunately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org