You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2022/01/03 23:47:09 UTC

[GitHub] [incubator-tuweni] ajsutton opened a new pull request #352: Add optimised update(MessageDigest) implementation for ConcatenatedBytes

ajsutton opened a new pull request #352:
URL: https://github.com/apache/incubator-tuweni/pull/352


   ## PR description
   Override the implementation of `update(MessageDigest)` in `ConcatenatedBytes` to avoid copying the concatenated values into a temporary array.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] ajsutton commented on pull request #352: Add optimised update(MessageDigest) implementation for ConcatenatedBytes

Posted by GitBox <gi...@apache.org>.
ajsutton commented on pull request #352:
URL: https://github.com/apache/incubator-tuweni/pull/352#issuecomment-1004587835


   Ah, worked out what it means by GitBox stuff now.  Going through that now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] ajsutton merged pull request #352: Add optimised update(MessageDigest) implementation for ConcatenatedBytes

Posted by GitBox <gi...@apache.org>.
ajsutton merged pull request #352:
URL: https://github.com/apache/incubator-tuweni/pull/352


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] ajsutton commented on pull request #352: Add optimised update(MessageDigest) implementation for ConcatenatedBytes

Posted by GitBox <gi...@apache.org>.
ajsutton commented on pull request #352:
URL: https://github.com/apache/incubator-tuweni/pull/352#issuecomment-1004586749


   I am part of the Apache org on GitHub (via adding my GitHub user to id.apache.org) but don't seem to have the role required for this repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] atoulme commented on pull request #352: Add optimised update(MessageDigest) implementation for ConcatenatedBytes

Posted by GitBox <gi...@apache.org>.
atoulme commented on pull request #352:
URL: https://github.com/apache/incubator-tuweni/pull/352#issuecomment-1004585528


   Weird. I think there is a simple step you need to take. Try this: https://infra.apache.org/apache-github.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] ajsutton commented on pull request #352: Add optimised update(MessageDigest) implementation for ConcatenatedBytes

Posted by GitBox <gi...@apache.org>.
ajsutton commented on pull request #352:
URL: https://github.com/apache/incubator-tuweni/pull/352#issuecomment-1004583470


   It turns out I still don't have write access to the repo so can't merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org