You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/05 22:16:26 UTC
[jira] [Commented] (TAJO-1892) Remove '_' as an identifier
[ https://issues.apache.org/jira/browse/TAJO-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943953#comment-14943953 ]
ASF GitHub Bot commented on TAJO-1892:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/788#issuecomment-145654750
@dkhwangbo Thank you for your work. But, asm module is a thirdparty package. So, we don't need to touch this source code. Instead, we should keep asm package using 1.7. For it, I'll add the following configuration in #778.
```
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.7</source>
<target>1.7</target>
</configuration>
```
> Remove '_' as an identifier
> ---------------------------
>
> Key: TAJO-1892
> URL: https://issues.apache.org/jira/browse/TAJO-1892
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Trivial
> Labels: newbie
>
> See this page.
> (https://bugs.openjdk.java.net/browse/JDK-8065599)
> Use of '_' as an identifier might not be supported in releases after java se 8. so, we must check code in whole project.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)