[GitHub] [kafka] vvcephei commented on pull request #10096: KAFKA-12268: Make early poll return opt-in

[GitBox <gi...@apache.org>]

vvcephei commented on pull request #10096:
URL: https://github.com/apache/kafka/pull/10096#issuecomment-776446769


   Hey @rajinisivaram and @chia7712 ,
   
   Here is my proposed fix for https://issues.apache.org/jira/browse/KAFKA-12268 , based on our discussion in https://github.com/apache/kafka/pull/10022 and in the mailing list (https://lists.apache.org/thread.html/ra3a73e74c2bb9768ce33dcf0492e2f0fd2f120044541c6b216a67cca%40%3Cdev.kafka.apache.org%3E)
   
   I don't know if anyone has a preference on the config name itself. I also considered just `enable.early.poll.return.on.metadata=false|true`, but _maybe_ there will be some other behavior we might add as another "mode" in the future. No strong opinion here.
   
   Also, please take a look at the logic in the Consumer. I did my best to make it both efficient and legible, but I'm not sure I achieved either goal.
   
   Thanks for spotting the problem and for the discussion, and thanks in advance for the reviews!
   
   Also, as the original reviewer of the feature, I'd appreciate a review from @guozhangwang if you have time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org