You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/05 06:43:12 UTC
[GitHub] [arrow] kou opened a new pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
kou opened a new pull request #7104:
URL: https://github.com/apache/arrow/pull/7104
We released NuGet packages as unofficial packages because we only vote
Apache Arrow C# source code. We didn't vote NuGet packages.
We can vote NuGet packages with this change. We can mark NuGet
packages as official packages in the next release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624127913
For what it's worth, did anyone even verify the C# source in the release? I know I couldn't get it to run, and I seemed to recall others saying they skipped it. That is to say, we should make sure our release verification process keeps up if we're adding more release artifacts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624305137
@github-actions crossbow submit nuget
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624439343
@github-actions crossbow submit nuget
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624415260
@github-actions crossbow submit nuget -g conda -g wheel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-623882796
Revision: 313121e43af798f1fd2a5190248ef60f1dd0ab65
Submitted crossbow builds: [ursa-labs/crossbow @ actions-203](https://github.com/ursa-labs/crossbow/branches/all?query=actions-203)
|Task|Status|
|----|------|
|nuget|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-203-github-nuget)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624415552
Revision: d30bf757239e9466befa92989268e047d385675a
Submitted crossbow builds: [ursa-labs/crossbow @ actions-207](https://github.com/ursa-labs/crossbow/branches/all?query=actions-207)
|Task|Status|
|----|------|
|conda-linux-gcc-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-conda-linux-gcc-py36)|
|conda-linux-gcc-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-conda-linux-gcc-py37)|
|conda-linux-gcc-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-conda-linux-gcc-py38)|
|conda-osx-clang-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-conda-osx-clang-py36)|
|conda-osx-clang-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-conda-osx-clang-py37)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-conda-osx-clang-py38)|
|conda-win-vs2015-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-conda-win-vs2015-py36)|
|conda-win-vs2015-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-conda-win-vs2015-py37)|
|conda-win-vs2015-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-conda-win-vs2015-py38)|
|nuget|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-207-github-nuget)|
|wheel-manylinux1-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux1-cp35m)|
|wheel-manylinux1-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux1-cp36m)|
|wheel-manylinux1-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux1-cp37m)|
|wheel-manylinux1-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux1-cp38)|
|wheel-manylinux2010-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux2010-cp35m)|
|wheel-manylinux2010-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux2010-cp36m)|
|wheel-manylinux2010-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux2010-cp37m)|
|wheel-manylinux2010-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux2010-cp38)|
|wheel-manylinux2014-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux2014-cp35m)|
|wheel-manylinux2014-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux2014-cp36m)|
|wheel-manylinux2014-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux2014-cp37m)|
|wheel-manylinux2014-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-207-azure-wheel-manylinux2014-cp38)|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-win-cp35m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp36m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624307564
Revision: b1195a40f123905c4c652b2aa63b5270b1d99c89
Submitted crossbow builds: [ursa-labs/crossbow @ actions-205](https://github.com/ursa-labs/crossbow/branches/all?query=actions-205)
|Task|Status|
|----|------|
|nuget|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-205-github-nuget)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624872213
I found a problem that URLs embedded in `.pdb` use fork repository (`kou/arrow` in this case). It's required for general cases. If we always use `apache/arrow` here, CI will be failure for commits that changes C# sources. But it must use `apache/arrow` in release process.
I'll work on this as a follow-up task.
I'll merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624444922
@github-actions crossbow submit nuget
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#discussion_r420516051
##########
File path: dev/tasks/crossbow.py
##########
@@ -706,7 +706,25 @@ def get_version(root, **kwargs):
'git describe --dirty --tags --long --match "apache-arrow-[0-9].*"'
)
version = parse_git_version(root, **kwargs)
- return version.format_next_version(guess_next_version)
+ next_version = version.format_next_version(guess_next_version)
+ # Ensure using ${MAJOR}.${MINOR}.${PATCH}-${SUFFIX} for pre-release version
+ # number. Because NuGet package requires this format for version number:
+ # https://docs.microsoft.com/en-us/nuget/concepts/package-versioning
+ #
+ # NuGet package version number follows Semantic Versioning 1.0.0:
+ # https://semver.org/spec/v1.0.0.html
+ #
+ # > A pre-release version number MAY be denoted by appending an
+ # > arbitrary string immediately following the patch version and a
+ # > dash. The string MUST be comprised of only alphanumerics plus
+ # > dash [0-9A-Za-z-].
+ #
+ # Example:
+ #
+ # '0.16.1.dev10' ->
+ # '0.16.1-dev10'
+ next_version = re.sub(r'\.(dev\d+)$', r'-\1', next_version)
+ return next_version
Review comment:
Umm... Conda doesn't like it:
```text
Error: bad character '-' in package/version: 0.17.1-dev124
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-623883273
https://issues.apache.org/jira/browse/ARROW-8702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#discussion_r420518768
##########
File path: dev/tasks/crossbow.py
##########
@@ -706,7 +706,25 @@ def get_version(root, **kwargs):
'git describe --dirty --tags --long --match "apache-arrow-[0-9].*"'
)
version = parse_git_version(root, **kwargs)
- return version.format_next_version(guess_next_version)
+ next_version = version.format_next_version(guess_next_version)
+ # Ensure using ${MAJOR}.${MINOR}.${PATCH}-${SUFFIX} for pre-release version
+ # number. Because NuGet package requires this format for version number:
+ # https://docs.microsoft.com/en-us/nuget/concepts/package-versioning
+ #
+ # NuGet package version number follows Semantic Versioning 1.0.0:
+ # https://semver.org/spec/v1.0.0.html
+ #
+ # > A pre-release version number MAY be denoted by appending an
+ # > arbitrary string immediately following the patch version and a
+ # > dash. The string MUST be comprised of only alphanumerics plus
+ # > dash [0-9A-Za-z-].
+ #
+ # Example:
+ #
+ # '0.16.1.dev10' ->
+ # '0.16.1-dev10'
+ next_version = re.sub(r'\.(dev\d+)$', r'-\1', next_version)
+ return next_version
Review comment:
I've added `arrow.no_rc_semver_version` instead of changing the current `arrow.version`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#discussion_r420516799
##########
File path: ci/scripts/csharp_nuget.sh
##########
@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -eux
+
+source_dir=${1}/csharp
+
+pushd ${source_dir}
+dotnet pack -c Release
+for pdb in artifacts/Apache.Arrow/Release/*/Apache.Arrow.pdb; do
+ sourcelink test ${pdb}
Review comment:
I agree with you.
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624299150
@github-actions crossbow submit -g conda -g wheel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#discussion_r420397797
##########
File path: dev/tasks/crossbow.py
##########
@@ -706,7 +706,25 @@ def get_version(root, **kwargs):
'git describe --dirty --tags --long --match "apache-arrow-[0-9].*"'
)
version = parse_git_version(root, **kwargs)
- return version.format_next_version(guess_next_version)
+ next_version = version.format_next_version(guess_next_version)
+ # Ensure using ${MAJOR}.${MINOR}.${PATCH}-${SUFFIX} for pre-release version
+ # number. Because NuGet package requires this format for version number:
+ # https://docs.microsoft.com/en-us/nuget/concepts/package-versioning
+ #
+ # NuGet package version number follows Semantic Versioning 1.0.0:
+ # https://semver.org/spec/v1.0.0.html
+ #
+ # > A pre-release version number MAY be denoted by appending an
+ # > arbitrary string immediately following the patch version and a
+ # > dash. The string MUST be comprised of only alphanumerics plus
+ # > dash [0-9A-Za-z-].
+ #
+ # Example:
+ #
+ # '0.16.1.dev10' ->
+ # '0.16.1-dev10'
+ next_version = re.sub(r'\.(dev\d+)$', r'-\1', next_version)
+ return next_version
Review comment:
OK. I'll run jobs for them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#discussion_r420041556
##########
File path: dev/tasks/crossbow.py
##########
@@ -706,7 +706,25 @@ def get_version(root, **kwargs):
'git describe --dirty --tags --long --match "apache-arrow-[0-9].*"'
)
version = parse_git_version(root, **kwargs)
- return version.format_next_version(guess_next_version)
+ next_version = version.format_next_version(guess_next_version)
+ # Ensure using ${MAJOR}.${MINOR}.${PATCH}-${SUFFIX} for pre-release version
+ # number. Because NuGet package requires this format for version number:
+ # https://docs.microsoft.com/en-us/nuget/concepts/package-versioning
+ #
+ # NuGet package version number follows Semantic Versioning 1.0.0:
+ # https://semver.org/spec/v1.0.0.html
+ #
+ # > A pre-release version number MAY be denoted by appending an
+ # > arbitrary string immediately following the patch version and a
+ # > dash. The string MUST be comprised of only alphanumerics plus
+ # > dash [0-9A-Za-z-].
+ #
+ # Example:
+ #
+ # '0.16.1.dev10' ->
+ # '0.16.1-dev10'
+ next_version = re.sub(r'\.(dev\d+)$', r'-\1', next_version)
+ return next_version
Review comment:
Looks fine for me, but we need to test whether the wheels and conda pkgs accept this format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624311266
Revision: b1195a40f123905c4c652b2aa63b5270b1d99c89
Submitted crossbow builds: [ursa-labs/crossbow @ actions-206](https://github.com/ursa-labs/crossbow/branches/all?query=actions-206)
|Task|Status|
|----|------|
|conda-linux-gcc-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-conda-linux-gcc-py36)|
|conda-linux-gcc-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-conda-linux-gcc-py37)|
|conda-linux-gcc-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-conda-linux-gcc-py38)|
|conda-osx-clang-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-conda-osx-clang-py36)|
|conda-osx-clang-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-conda-osx-clang-py37)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-conda-osx-clang-py38)|
|conda-win-vs2015-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-conda-win-vs2015-py36)|
|conda-win-vs2015-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-conda-win-vs2015-py37)|
|conda-win-vs2015-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-conda-win-vs2015-py38)|
|wheel-manylinux1-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux1-cp35m)|
|wheel-manylinux1-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux1-cp36m)|
|wheel-manylinux1-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux1-cp37m)|
|wheel-manylinux1-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux1-cp38)|
|wheel-manylinux2010-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux2010-cp35m)|
|wheel-manylinux2010-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux2010-cp36m)|
|wheel-manylinux2010-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux2010-cp37m)|
|wheel-manylinux2010-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux2010-cp38)|
|wheel-manylinux2014-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux2014-cp35m)|
|wheel-manylinux2014-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux2014-cp36m)|
|wheel-manylinux2014-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux2014-cp37m)|
|wheel-manylinux2014-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-206-azure-wheel-manylinux2014-cp38)|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-win-cp35m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp36m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624313703
@nealrichardson I always verified C# source in each release. The verification always passes tests but failed `sourcelink test`. So I always report "I skipped C# source verification".
The `sourcelink test` failure has been fixed in #7040. We will not need to skip C# source verification in the next release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624310635
@github-actions crossbow submit -g conda -g wheel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624445211
Revision: ffc2ac2f0c4ca362b21e351112c7619c42f4ae2c
Submitted crossbow builds: [ursa-labs/crossbow @ actions-209](https://github.com/ursa-labs/crossbow/branches/all?query=actions-209)
|Task|Status|
|----|------|
|nuget|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-209-github-nuget)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] eerhardt commented on a change in pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
eerhardt commented on a change in pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#discussion_r420422699
##########
File path: docker-compose.yml
##########
@@ -1015,7 +1015,8 @@ services:
command: &csharp-command >
/bin/bash -c "
/arrow/ci/scripts/csharp_build.sh /arrow &&
- /arrow/ci/scripts/csharp_test.sh /arrow"
+ /arrow/ci/scripts/csharp_test.sh /arrow &&
+ /arrow/ci/scripts/csharp_nuget.sh /arrow"
Review comment:
(nit) I think I would call this `csharp_pack.sh`. `pack` is the verb we use in the tooling: `dotnet build`, `dotnet test`, and `dotnet pack`.
##########
File path: ci/scripts/csharp_nuget.sh
##########
@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -eux
+
+source_dir=${1}/csharp
+
+pushd ${source_dir}
+dotnet pack -c Release
+for pdb in artifacts/Apache.Arrow/Release/*/Apache.Arrow.pdb; do
+ sourcelink test ${pdb}
Review comment:
What do you think about putting this in `csharp_test.sh` instead? This operation is more about testing what was built during `dotnet build` is correct. It actually doesn't do anything with the artifacts created by `dotnet pack`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624439626
Revision: 02978b4a2b7ebf2301ca555a1eaa940c0230e2fc
Submitted crossbow builds: [ursa-labs/crossbow @ actions-208](https://github.com/ursa-labs/crossbow/branches/all?query=actions-208)
|Task|Status|
|----|------|
|nuget|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-208-github-nuget)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#discussion_r419895904
##########
File path: dev/tasks/crossbow.py
##########
@@ -706,7 +706,25 @@ def get_version(root, **kwargs):
'git describe --dirty --tags --long --match "apache-arrow-[0-9].*"'
)
version = parse_git_version(root, **kwargs)
- return version.format_next_version(guess_next_version)
+ next_version = version.format_next_version(guess_next_version)
+ # Ensure using ${MAJOR}.${MINOR}.${PATCH}-${SUFFIX} for pre-release version
+ # number. Because NuGet package requires this format for version number:
+ # https://docs.microsoft.com/en-us/nuget/concepts/package-versioning
+ #
+ # NuGet package version number follows Semantic Versioning 1.0.0:
+ # https://semver.org/spec/v1.0.0.html
+ #
+ # > A pre-release version number MAY be denoted by appending an
+ # > arbitrary string immediately following the patch version and a
+ # > dash. The string MUST be comprised of only alphanumerics plus
+ # > dash [0-9A-Za-z-].
+ #
+ # Example:
+ #
+ # '0.16.1.dev10' ->
+ # '0.16.1-dev10'
+ next_version = re.sub(r'\.(dev\d+)$', r'-\1', next_version)
+ return next_version
Review comment:
@kszucs What do you think about this? Is it acceptable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624318158
@eerhardt Could you confirm whether NuGet packages at https://github.com/ursa-labs/crossbow/releases/tag/actions-205-github-nuget is valid?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#discussion_r420516736
##########
File path: docker-compose.yml
##########
@@ -1015,7 +1015,8 @@ services:
command: &csharp-command >
/bin/bash -c "
/arrow/ci/scripts/csharp_build.sh /arrow &&
- /arrow/ci/scripts/csharp_test.sh /arrow"
+ /arrow/ci/scripts/csharp_test.sh /arrow &&
+ /arrow/ci/scripts/csharp_nuget.sh /arrow"
Review comment:
It makes sense! Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624413841
@eerhardt Thanks for confirming the packages!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-623882366
@github-actions crossbow submit nuget
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7104: ARROW-8702: [Packaging][C#] Build NuGet packages in release process
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#issuecomment-624307007
@github-actions crossbow submit nuget
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org