You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by dw...@apache.org on 2009/02/23 22:13:05 UTC
svn commit: r747138 -
/geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
Author: dwoods
Date: Mon Feb 23 21:12:59 2009
New Revision: 747138
URL: http://svn.apache.org/viewvc?rev=747138&view=rev
Log:
GERONIMO-4541 Upgrade to ASM 3.1. Missed upgrading a test.
Modified:
geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
Modified: geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml?rev=747138&r1=747137&r2=747138&view=diff
==============================================================================
--- geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml (original)
+++ geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml Mon Feb 23 21:12:59 2009
@@ -74,7 +74,7 @@
<dependency>
<groupId>asm</groupId>
<artifactId>asm</artifactId>
- <version>2.2.3</version>
+ <version>3.1</version>
<type>jar</type>
<import>classes</import>
</dependency>
@@ -88,7 +88,7 @@
<dependency>
<groupId>asm</groupId>
<artifactId>asm-commons</artifactId>
- <version>2.2.3</version>
+ <version>3.1</version>
<type>jar</type>
<import>classes</import>
</dependency>
Re: svn commit: r747138 - /geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
Posted by Joe Bohn <jo...@earthlink.net>.
I noticed that xbean-reflect 3.5 still includes a dependency on asm
2.2.3. We might need to update xbean before we can get rid of these
conflicts.
Joe
Joe Bohn wrote:
> Hmmm ... we still haven't found the core issue here. The same tests are
> still failing with both files updated and the assembly images include
> both 2.2.3 and 3.1 asm artifacts.
>
> Still looking ....
>
> Joe
>
>
> Joe Bohn wrote:
>> Hey Donald,
>>
>> I think you also need to update
>> framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/geronimo-plugin.xml
>>
>>
>> I'm building (with tests) right now with both of these changes so
>> ensure it resolves the issues.
>>
>> Joe
>>
>>
>> dwoods@apache.org wrote:
>>> Author: dwoods
>>> Date: Mon Feb 23 21:12:59 2009
>>> New Revision: 747138
>>>
>>> URL: http://svn.apache.org/viewvc?rev=747138&view=rev
>>> Log:
>>> GERONIMO-4541 Upgrade to ASM 3.1. Missed upgrading a test.
>>>
>>> Modified:
>>>
>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>
>>>
>>> Modified:
>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml?rev=747138&r1=747137&r2=747138&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>> (original)
>>> +++
>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>> Mon Feb 23 21:12:59 2009
>>> @@ -74,7 +74,7 @@
>>> <dependency>
>>> <groupId>asm</groupId>
>>> <artifactId>asm</artifactId>
>>> - <version>2.2.3</version>
>>> + <version>3.1</version>
>>> <type>jar</type>
>>> <import>classes</import>
>>> </dependency>
>>> @@ -88,7 +88,7 @@
>>> <dependency>
>>> <groupId>asm</groupId>
>>> <artifactId>asm-commons</artifactId>
>>> - <version>2.2.3</version>
>>> + <version>3.1</version>
>>> <type>jar</type>
>>> <import>classes</import>
>>> </dependency>
>>>
>>>
>>>
>>
>>
>
>
Re: svn commit: r747138 - /geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
Posted by David Blevins <da...@visi.com>.
On it.
-David
On Feb 24, 2009, at 8:41 AM, Joe Bohn wrote:
> I confirmed that these failures are at least impacted by an OpenEJB
> change - rev. 745185. When I reverted this change and built OpenEJB
> 3.0.1-SNAPSHOT locally the tests all passed. So there is either
> something wrong with the OpenEJB change or something must change in
> Geronimo and/or tests cases to accommodate it.
>
> Can somebody more familiar with OpenEJB look into this further?
>
> Thanks,
> Joe
>
>
> Joe Bohn wrote:
>> grrr .... still no love. Even with the other updates (just checked
>> in with rev. 747177) I'm still seeing the same failures. However,
>> the assemblies now only include asm 3.1. I guess it might still be
>> xbean-reflect ...
>> Joe
>> Joe Bohn wrote:
>>> Thanks Jarek.
>>>
>>> I had noticed that one as well in my grep. However when I saw it
>>> I was mistakenly thinking of the dependencies.xml file (as in
>>> trunk) and was going to let the build fail before updating to
>>> ensure it needed to change :-) ... too many different xml files.
>>> I'll update that too and see if that is the last item. I hope
>>> that we don't need to re-release xbean.
>>>
>>> Joe
>>>
>>>
>>> Jarek Gawor wrote:
>>>> Joe,
>>>>
>>>> Check ./plugins/openejb/geronimo-openejb/src/main/resources/META-
>>>> INF/geronimo-dependency.xml
>>>>
>>>> Jarek
>>>>
>>>> On Mon, Feb 23, 2009 at 4:44 PM, Joe Bohn
>>>> <jo...@earthlink.net> wrote:
>>>>> Hmmm ... we still haven't found the core issue here. The same
>>>>> tests are
>>>>> still failing with both files updated and the assembly images
>>>>> include both
>>>>> 2.2.3 and 3.1 asm artifacts.
>>>>>
>>>>> Still looking ....
>>>>>
>>>>> Joe
>>>>>
>>>>>
>>>>> Joe Bohn wrote:
>>>>>> Hey Donald,
>>>>>>
>>>>>> I think you also need to update
>>>>>>
>>>>>> framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/
>>>>>> src/test/resources/META-INF/geronimo-plugin.xml
>>>>>>
>>>>>> I'm building (with tests) right now with both of these changes
>>>>>> so ensure
>>>>>> it resolves the issues.
>>>>>>
>>>>>> Joe
>>>>>>
>>>>>>
>>>>>> dwoods@apache.org wrote:
>>>>>>> Author: dwoods
>>>>>>> Date: Mon Feb 23 21:12:59 2009
>>>>>>> New Revision: 747138
>>>>>>>
>>>>>>> URL: http://svn.apache.org/viewvc?rev=747138&view=rev
>>>>>>> Log:
>>>>>>> GERONIMO-4541 Upgrade to ASM 3.1. Missed upgrading a test.
>>>>>>>
>>>>>>> Modified:
>>>>>>>
>>>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-
>>>>>>> deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>>>
>>>>>>> Modified:
>>>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-
>>>>>>> deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>>> URL:
>>>>>>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml?rev=747138&r1=747137&r2=747138&view=diff
>>>>>>>
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> =
>>>>>>> ================================================================
>>>>>>> ---
>>>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-
>>>>>>> deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>>> (original)
>>>>>>> +++
>>>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-
>>>>>>> deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>>> Mon Feb 23 21:12:59 2009
>>>>>>> @@ -74,7 +74,7 @@
>>>>>>> <dependency>
>>>>>>> <groupId>asm</groupId>
>>>>>>> <artifactId>asm</artifactId>
>>>>>>> - <version>2.2.3</version>
>>>>>>> + <version>3.1</version>
>>>>>>> <type>jar</type>
>>>>>>> <import>classes</import>
>>>>>>> </dependency>
>>>>>>> @@ -88,7 +88,7 @@
>>>>>>> <dependency>
>>>>>>> <groupId>asm</groupId>
>>>>>>> <artifactId>asm-commons</artifactId>
>>>>>>> - <version>2.2.3</version>
>>>>>>> + <version>3.1</version>
>>>>>>> <type>jar</type>
>>>>>>> <import>classes</import>
>>>>>>> </dependency>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>
>
Re: svn commit: r747138 - /geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
Posted by Joe Bohn <jo...@earthlink.net>.
I confirmed that these failures are at least impacted by an OpenEJB
change - rev. 745185. When I reverted this change and built OpenEJB
3.0.1-SNAPSHOT locally the tests all passed. So there is either
something wrong with the OpenEJB change or something must change in
Geronimo and/or tests cases to accommodate it.
Can somebody more familiar with OpenEJB look into this further?
Thanks,
Joe
Joe Bohn wrote:
> grrr .... still no love. Even with the other updates (just checked in
> with rev. 747177) I'm still seeing the same failures. However, the
> assemblies now only include asm 3.1. I guess it might still be
> xbean-reflect ...
>
> Joe
>
> Joe Bohn wrote:
>> Thanks Jarek.
>>
>> I had noticed that one as well in my grep. However when I saw it I
>> was mistakenly thinking of the dependencies.xml file (as in trunk) and
>> was going to let the build fail before updating to ensure it needed to
>> change :-) ... too many different xml files. I'll update that too
>> and see if that is the last item. I hope that we don't need to
>> re-release xbean.
>>
>> Joe
>>
>>
>> Jarek Gawor wrote:
>>> Joe,
>>>
>>> Check
>>> ./plugins/openejb/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml
>>>
>>>
>>> Jarek
>>>
>>> On Mon, Feb 23, 2009 at 4:44 PM, Joe Bohn <jo...@earthlink.net>
>>> wrote:
>>>> Hmmm ... we still haven't found the core issue here. The same tests
>>>> are
>>>> still failing with both files updated and the assembly images
>>>> include both
>>>> 2.2.3 and 3.1 asm artifacts.
>>>>
>>>> Still looking ....
>>>>
>>>> Joe
>>>>
>>>>
>>>> Joe Bohn wrote:
>>>>> Hey Donald,
>>>>>
>>>>> I think you also need to update
>>>>>
>>>>> framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/geronimo-plugin.xml
>>>>>
>>>>>
>>>>> I'm building (with tests) right now with both of these changes so
>>>>> ensure
>>>>> it resolves the issues.
>>>>>
>>>>> Joe
>>>>>
>>>>>
>>>>> dwoods@apache.org wrote:
>>>>>> Author: dwoods
>>>>>> Date: Mon Feb 23 21:12:59 2009
>>>>>> New Revision: 747138
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=747138&view=rev
>>>>>> Log:
>>>>>> GERONIMO-4541 Upgrade to ASM 3.1. Missed upgrading a test.
>>>>>>
>>>>>> Modified:
>>>>>>
>>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>>
>>>>>>
>>>>>> Modified:
>>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>>
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml?rev=747138&r1=747137&r2=747138&view=diff
>>>>>>
>>>>>>
>>>>>> ==============================================================================
>>>>>>
>>>>>> ---
>>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>>
>>>>>> (original)
>>>>>> +++
>>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>>
>>>>>> Mon Feb 23 21:12:59 2009
>>>>>> @@ -74,7 +74,7 @@
>>>>>> <dependency>
>>>>>> <groupId>asm</groupId>
>>>>>> <artifactId>asm</artifactId>
>>>>>> - <version>2.2.3</version>
>>>>>> + <version>3.1</version>
>>>>>> <type>jar</type>
>>>>>> <import>classes</import>
>>>>>> </dependency>
>>>>>> @@ -88,7 +88,7 @@
>>>>>> <dependency>
>>>>>> <groupId>asm</groupId>
>>>>>> <artifactId>asm-commons</artifactId>
>>>>>> - <version>2.2.3</version>
>>>>>> + <version>3.1</version>
>>>>>> <type>jar</type>
>>>>>> <import>classes</import>
>>>>>> </dependency>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>>
>
>
Re: svn commit: r747138 - /geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
Posted by Joe Bohn <jo...@earthlink.net>.
grrr .... still no love. Even with the other updates (just checked in
with rev. 747177) I'm still seeing the same failures. However, the
assemblies now only include asm 3.1. I guess it might still be
xbean-reflect ...
Joe
Joe Bohn wrote:
> Thanks Jarek.
>
> I had noticed that one as well in my grep. However when I saw it I was
> mistakenly thinking of the dependencies.xml file (as in trunk) and was
> going to let the build fail before updating to ensure it needed to
> change :-) ... too many different xml files. I'll update that too and
> see if that is the last item. I hope that we don't need to re-release
> xbean.
>
> Joe
>
>
> Jarek Gawor wrote:
>> Joe,
>>
>> Check
>> ./plugins/openejb/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml
>>
>>
>> Jarek
>>
>> On Mon, Feb 23, 2009 at 4:44 PM, Joe Bohn <jo...@earthlink.net> wrote:
>>> Hmmm ... we still haven't found the core issue here. The same tests are
>>> still failing with both files updated and the assembly images include
>>> both
>>> 2.2.3 and 3.1 asm artifacts.
>>>
>>> Still looking ....
>>>
>>> Joe
>>>
>>>
>>> Joe Bohn wrote:
>>>> Hey Donald,
>>>>
>>>> I think you also need to update
>>>>
>>>> framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/geronimo-plugin.xml
>>>>
>>>>
>>>> I'm building (with tests) right now with both of these changes so
>>>> ensure
>>>> it resolves the issues.
>>>>
>>>> Joe
>>>>
>>>>
>>>> dwoods@apache.org wrote:
>>>>> Author: dwoods
>>>>> Date: Mon Feb 23 21:12:59 2009
>>>>> New Revision: 747138
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=747138&view=rev
>>>>> Log:
>>>>> GERONIMO-4541 Upgrade to ASM 3.1. Missed upgrading a test.
>>>>>
>>>>> Modified:
>>>>>
>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>
>>>>>
>>>>> Modified:
>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml?rev=747138&r1=747137&r2=747138&view=diff
>>>>>
>>>>>
>>>>> ==============================================================================
>>>>>
>>>>> ---
>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>
>>>>> (original)
>>>>> +++
>>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>>
>>>>> Mon Feb 23 21:12:59 2009
>>>>> @@ -74,7 +74,7 @@
>>>>> <dependency>
>>>>> <groupId>asm</groupId>
>>>>> <artifactId>asm</artifactId>
>>>>> - <version>2.2.3</version>
>>>>> + <version>3.1</version>
>>>>> <type>jar</type>
>>>>> <import>classes</import>
>>>>> </dependency>
>>>>> @@ -88,7 +88,7 @@
>>>>> <dependency>
>>>>> <groupId>asm</groupId>
>>>>> <artifactId>asm-commons</artifactId>
>>>>> - <version>2.2.3</version>
>>>>> + <version>3.1</version>
>>>>> <type>jar</type>
>>>>> <import>classes</import>
>>>>> </dependency>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>
>
Re: svn commit: r747138 - /geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
Posted by Joe Bohn <jo...@earthlink.net>.
Thanks Jarek.
I had noticed that one as well in my grep. However when I saw it I was
mistakenly thinking of the dependencies.xml file (as in trunk) and was
going to let the build fail before updating to ensure it needed to
change :-) ... too many different xml files. I'll update that too and
see if that is the last item. I hope that we don't need to re-release
xbean.
Joe
Jarek Gawor wrote:
> Joe,
>
> Check ./plugins/openejb/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml
>
> Jarek
>
> On Mon, Feb 23, 2009 at 4:44 PM, Joe Bohn <jo...@earthlink.net> wrote:
>> Hmmm ... we still haven't found the core issue here. The same tests are
>> still failing with both files updated and the assembly images include both
>> 2.2.3 and 3.1 asm artifacts.
>>
>> Still looking ....
>>
>> Joe
>>
>>
>> Joe Bohn wrote:
>>> Hey Donald,
>>>
>>> I think you also need to update
>>>
>>> framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/geronimo-plugin.xml
>>>
>>> I'm building (with tests) right now with both of these changes so ensure
>>> it resolves the issues.
>>>
>>> Joe
>>>
>>>
>>> dwoods@apache.org wrote:
>>>> Author: dwoods
>>>> Date: Mon Feb 23 21:12:59 2009
>>>> New Revision: 747138
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=747138&view=rev
>>>> Log:
>>>> GERONIMO-4541 Upgrade to ASM 3.1. Missed upgrading a test.
>>>>
>>>> Modified:
>>>>
>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>>
>>>> Modified:
>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml?rev=747138&r1=747137&r2=747138&view=diff
>>>>
>>>> ==============================================================================
>>>> ---
>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>> (original)
>>>> +++
>>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>> Mon Feb 23 21:12:59 2009
>>>> @@ -74,7 +74,7 @@
>>>> <dependency>
>>>> <groupId>asm</groupId>
>>>> <artifactId>asm</artifactId>
>>>> - <version>2.2.3</version>
>>>> + <version>3.1</version>
>>>> <type>jar</type>
>>>> <import>classes</import>
>>>> </dependency>
>>>> @@ -88,7 +88,7 @@
>>>> <dependency>
>>>> <groupId>asm</groupId>
>>>> <artifactId>asm-commons</artifactId>
>>>> - <version>2.2.3</version>
>>>> + <version>3.1</version>
>>>> <type>jar</type>
>>>> <import>classes</import>
>>>> </dependency>
>>>>
>>>>
>>>>
>>>
>>
>
Re: svn commit: r747138 - /geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
Posted by Jarek Gawor <jg...@gmail.com>.
Joe,
Check ./plugins/openejb/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml
Jarek
On Mon, Feb 23, 2009 at 4:44 PM, Joe Bohn <jo...@earthlink.net> wrote:
> Hmmm ... we still haven't found the core issue here. The same tests are
> still failing with both files updated and the assembly images include both
> 2.2.3 and 3.1 asm artifacts.
>
> Still looking ....
>
> Joe
>
>
> Joe Bohn wrote:
>>
>> Hey Donald,
>>
>> I think you also need to update
>>
>> framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/geronimo-plugin.xml
>>
>> I'm building (with tests) right now with both of these changes so ensure
>> it resolves the issues.
>>
>> Joe
>>
>>
>> dwoods@apache.org wrote:
>>>
>>> Author: dwoods
>>> Date: Mon Feb 23 21:12:59 2009
>>> New Revision: 747138
>>>
>>> URL: http://svn.apache.org/viewvc?rev=747138&view=rev
>>> Log:
>>> GERONIMO-4541 Upgrade to ASM 3.1. Missed upgrading a test.
>>>
>>> Modified:
>>>
>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>>
>>> Modified:
>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>> URL:
>>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml?rev=747138&r1=747137&r2=747138&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>> (original)
>>> +++
>>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>> Mon Feb 23 21:12:59 2009
>>> @@ -74,7 +74,7 @@
>>> <dependency>
>>> <groupId>asm</groupId>
>>> <artifactId>asm</artifactId>
>>> - <version>2.2.3</version>
>>> + <version>3.1</version>
>>> <type>jar</type>
>>> <import>classes</import>
>>> </dependency>
>>> @@ -88,7 +88,7 @@
>>> <dependency>
>>> <groupId>asm</groupId>
>>> <artifactId>asm-commons</artifactId>
>>> - <version>2.2.3</version>
>>> + <version>3.1</version>
>>> <type>jar</type>
>>> <import>classes</import>
>>> </dependency>
>>>
>>>
>>>
>>
>>
>
>
Re: svn commit: r747138 - /geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
Posted by Joe Bohn <jo...@earthlink.net>.
Hmmm ... we still haven't found the core issue here. The same tests are
still failing with both files updated and the assembly images include
both 2.2.3 and 3.1 asm artifacts.
Still looking ....
Joe
Joe Bohn wrote:
> Hey Donald,
>
> I think you also need to update
> framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/geronimo-plugin.xml
>
>
> I'm building (with tests) right now with both of these changes so ensure
> it resolves the issues.
>
> Joe
>
>
> dwoods@apache.org wrote:
>> Author: dwoods
>> Date: Mon Feb 23 21:12:59 2009
>> New Revision: 747138
>>
>> URL: http://svn.apache.org/viewvc?rev=747138&view=rev
>> Log:
>> GERONIMO-4541 Upgrade to ASM 3.1. Missed upgrading a test.
>>
>> Modified:
>>
>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>
>>
>> Modified:
>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>>
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml?rev=747138&r1=747137&r2=747138&view=diff
>>
>> ==============================================================================
>>
>> ---
>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>> (original)
>> +++
>> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>> Mon Feb 23 21:12:59 2009
>> @@ -74,7 +74,7 @@
>> <dependency>
>> <groupId>asm</groupId>
>> <artifactId>asm</artifactId>
>> - <version>2.2.3</version>
>> + <version>3.1</version>
>> <type>jar</type>
>> <import>classes</import>
>> </dependency>
>> @@ -88,7 +88,7 @@
>> <dependency>
>> <groupId>asm</groupId>
>> <artifactId>asm-commons</artifactId>
>> - <version>2.2.3</version>
>> + <version>3.1</version>
>> <type>jar</type>
>> <import>classes</import>
>> </dependency>
>>
>>
>>
>
>
Re: svn commit: r747138 - /geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
Posted by Joe Bohn <jo...@earthlink.net>.
Hey Donald,
I think you also need to update
framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/geronimo-plugin.xml
I'm building (with tests) right now with both of these changes so ensure
it resolves the issues.
Joe
dwoods@apache.org wrote:
> Author: dwoods
> Date: Mon Feb 23 21:12:59 2009
> New Revision: 747138
>
> URL: http://svn.apache.org/viewvc?rev=747138&view=rev
> Log:
> GERONIMO-4541 Upgrade to ASM 3.1. Missed upgrading a test.
>
> Modified:
> geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
>
> Modified: geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml?rev=747138&r1=747137&r2=747138&view=diff
> ==============================================================================
> --- geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml (original)
> +++ geronimo/server/branches/2.1/framework/configs/geronimo-gbean-deployer/src/it/j2ee-system/src/test/resources/META-INF/plan.xml Mon Feb 23 21:12:59 2009
> @@ -74,7 +74,7 @@
> <dependency>
> <groupId>asm</groupId>
> <artifactId>asm</artifactId>
> - <version>2.2.3</version>
> + <version>3.1</version>
> <type>jar</type>
> <import>classes</import>
> </dependency>
> @@ -88,7 +88,7 @@
> <dependency>
> <groupId>asm</groupId>
> <artifactId>asm-commons</artifactId>
> - <version>2.2.3</version>
> + <version>3.1</version>
> <type>jar</type>
> <import>classes</import>
> </dependency>
>
>
>