You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/08/15 12:55:16 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #778: Add SMISMEMBER support

git-hulk commented on code in PR #778:
URL: https://github.com/apache/incubator-kvrocks/pull/778#discussion_r945695256


##########
src/redis_cmd.cc:
##########
@@ -1985,6 +1985,31 @@ class CommandSIsMember : public Commander {
   }
 };
 
+class CommandSMIsMember : public Commander {
+ public:
+  Status Execute(Server *svr, Connection *conn, std::string *output) override {
+    Redis::Set set_db(svr->storage_, conn->GetNamespace());
+    std::vector<Slice> members;
+    for (unsigned int i = 2; i < args_.size(); i++) {

Review Comment:
   ```suggestion
       for (size_t i = 2; i < args_.size(); i++) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org