You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/08/18 20:26:43 UTC

Review Request 37587: Add Unavailable HTTP response.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37587/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Ben Mahler.


Bugs: MESOS-3290
    https://issues.apache.org/jira/browse/MESOS-3290


Repository: mesos


Description
-------

Needed this for subsequent review.


Diffs
-----

  3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2 

Diff: https://reviews.apache.org/r/37587/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 37587: Add Unavailable HTTP response.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37587/#review95755
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Aug. 18, 2015, 6:26 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37587/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-3290
>     https://issues.apache.org/jira/browse/MESOS-3290
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Needed this for subsequent review.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2 
> 
> Diff: https://reviews.apache.org/r/37587/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 37587: Add Unavailable HTTP response.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37587/#review95757
-----------------------------------------------------------



3rdparty/libprocess/include/process/http.hpp (lines 590 - 601)
<https://reviews.apache.org/r/37587/#comment150867>

    Actually, nevermind, this already exists :)


- Ben Mahler


On Aug. 18, 2015, 6:26 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37587/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-3290
>     https://issues.apache.org/jira/browse/MESOS-3290
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Needed this for subsequent review.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2 
> 
> Diff: https://reviews.apache.org/r/37587/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>