You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/07/26 17:51:58 UTC

[PR] [SPARK-49020] Avoid `raw` type usage [spark-kubernetes-operator]

dongjoon-hyun opened a new pull request, #26:
URL: https://github.com/apache/spark-kubernetes-operator/pull/26

   ### What changes were proposed in this pull request?
   
   This PR aims to avoid `raw` type usage.
   
   ### Why are the changes needed?
   
   We need to use use generic types like the following.
   ```
   -          Class listenerClass = Class.forName(name);
   +          Class<?> listenerClass = Class.forName(name);
   ```
   
   ```
   -  public static Object resolveValueToPrimitiveType(Class clazz, String value) {
   +  public static Object resolveValueToPrimitiveType(Class<?> clazz, String value) {
   ```
   
   Or, we can use `var` syntax.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Pass the CIs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-49020] Avoid `raw` type usage [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #26:
URL: https://github.com/apache/spark-kubernetes-operator/pull/26#issuecomment-2253225023

   Could you review this, @jiangzho and @viirya ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-49020] Avoid `raw` type usage [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #26: [SPARK-49020] Avoid `raw` type usage
URL: https://github.com/apache/spark-kubernetes-operator/pull/26


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-49020] Avoid `raw` type usage [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #26:
URL: https://github.com/apache/spark-kubernetes-operator/pull/26#issuecomment-2253660716

   Thank you, @viirya .
   Merged to main.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org