You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "hc-leo (via GitHub)" <gi...@apache.org> on 2023/06/02 09:20:19 UTC
[GitHub] [dolphinscheduler] hc-leo opened a new issue, #14269: [Bug] [Task Group] Cannot authorize task group to non-admin user
hc-leo opened a new issue, #14269:
URL: https://github.com/apache/dolphinscheduler/issues/14269
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
An non-admin user cannot select the task group created by others/admin when creating a task.
In another word, non-admin user can only see the task group created by himself, which makes the task group an useless function.
### What you expected to happen
After a task group being created, the admin should have the option to authorize this task group to an ordinary user in User Manage page. (Now there are only file resource and udf resource can be authorized)
### How to reproduce
1. Login as User A and create a project and a task group related to this project.
2. Authorize the project to user B.
3. Login in as user B and create a Task. Click "Task group name" and the drop-down box shows nothing.
### Anything else
There is no option to allow normal users to access this resource in Security management page or Resources.
### Version
3.1.x
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity commented on issue #14269: [Bug] [Task Group] Cannot authorize task group to non-admin user
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on issue #14269:
URL: https://github.com/apache/dolphinscheduler/issues/14269#issuecomment-1575382689
Good catch, technically, no matter whether user is admin or non-admin, they can only use the task group created by themselves, you can change to a clearer issue title :D
https://github.com/apache/dolphinscheduler/blob/85b581b232f22cbb382b0f133bd9aa041edd0178/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/TaskGroupMapper.xml#L125-L133
I think, at least, task group should be project level, and in this way, we don't have to add task group authorization, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity commented on issue #14269: [Bug] [Task Group] no matter whether user is admin or non-admin, they can only use the task group created by themselves
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on issue #14269:
URL: https://github.com/apache/dolphinscheduler/issues/14269#issuecomment-1610973760
Hi, @hc-leo , welcome to join the discussion https://github.com/apache/dolphinscheduler/pull/14392#discussion_r1244743244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity commented on issue #14269: [Bug] [Task Group] no matter whether user is admin or non-admin, they can only use the task group created by themselves
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on issue #14269:
URL: https://github.com/apache/dolphinscheduler/issues/14269#issuecomment-1590612908
Current design is unreasonable, I will help to improve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS closed issue #14269: [Bug] [Task Group] no matter whether user is admin or non-admin, they can only use the task group created by themselves
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed issue #14269: [Bug] [Task Group] no matter whether user is admin or non-admin, they can only use the task group created by themselves
URL: https://github.com/apache/dolphinscheduler/issues/14269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #14269: [Bug] [Task Group] Cannot authorize task group to non-admin user
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #14269:
URL: https://github.com/apache/dolphinscheduler/issues/14269#issuecomment-1573424179
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information, version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hc-leo commented on issue #14269: [Bug] [Task Group] no matter whether user is admin or non-admin, they can only use the task group created by themselves
Posted by "hc-leo (via GitHub)" <gi...@apache.org>.
hc-leo commented on issue #14269:
URL: https://github.com/apache/dolphinscheduler/issues/14269#issuecomment-1590605516
> Good catch, technically, no matter whether user is admin or non-admin, they can only use the task group created by themselves, you can change to a clearer issue title :D
>
> https://github.com/apache/dolphinscheduler/blob/85b581b232f22cbb382b0f133bd9aa041edd0178/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/TaskGroupMapper.xml#L125-L133
>
> I think task group should be project level, and in this way, we don't have to add task group authorization, WDYT?
Thanks for your paraphrase, that's definitely what I want to say
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org