[GitHub] [royale-asjs] mrvx23 opened a new pull request #580: Fix navigationlink href value always being #

[GitBox <gi...@apache.org>]

mrvx23 opened a new pull request #580: Fix navigationlink href value always being #
URL: https://github.com/apache/royale-asjs/pull/580
 
 
   NavigationLinkItemRender reads the href value of the link out of it's data object .href property.
   
   Expected:
   NavigationLinkItemRenderer gets compiled into an anchor tag with the specified href value.
   
   Actual:
   NavigationLinkItemRenderer gets compiled into an anchor tag with href="#".
   
   This is due to the internal logic of processing the href value, which seems to have broken due to indirect changes in (parent?) components. Href is only considered if an internal textNode is present, but in reality, the anchor tag and the child textNode should be handled independently.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services