[GitHub] [incubator-superset] rusackas commented on a change in pull request #10105: fix: Loading overlay bugfix and cleanup

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #10105:
URL: https://github.com/apache/incubator-superset/pull/10105#discussion_r443724517



##########
File path: superset-frontend/src/SqlLab/components/TableElement.jsx
##########
@@ -207,7 +207,7 @@ class TableElement extends React.PureComponent {
         </div>
         <div className="pull-right">
           {table.isMetadataLoading || table.isExtraMetadataLoading ? (
-            <Loading size={50} position="normal" className="margin-zero" />

Review comment:
       As it was, the size prop passed through to a css property of "size" rather than "height/width" so it never really worked in the first place. Since it's not being used, I'm inclined to scrap it (less code, hooray!) and if we need it for some use case, consider setting up some Theme variables for icon sizes (e.g. s/m/l/xl), and implementing those instead.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org