[GitHub] [airflow] potiuk commented on pull request #29935: Fix for Windows

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on PR #29935:
URL: https://github.com/apache/airflow/pull/29935#issuecomment-1461691757

   @casra-developers - I think havinb half-baked solutions like that is just a starting point. What I am worried about is that it has no support for testing it and that it does not prevent (and will not prevent) anyone from using non-windows compliant behaviours in the future. But maybe this PR might be turned in something more complete.
   
   We have https://github.com/apache/airflow/issues/12874 and https://github.com/apache/airflow/issues/10388 opened to make Airflow works for Windows.  And Honestly, I do not think we are far from at least being able to run airflow on Windows for local development natively.
   
   My idea and suggestion for this PR - why don't we try to make a running set of tests for Windows as part of the a Airflow CI - at least for some basic "airflow" tests. It does not have to be complete set of tests, but just running the "Core" and "Always" tests on a simple "airflow" installation without any extras. This will not use any of the Breeze testing framework - which is more complete and comprehensive, but it woul just make sure that 
   
   a) you can create airflow virtualenv on windows
   b) you can install plain "airflow" there
   c) you can run all the tests that are "Core" and "Airflow" and they succeed
   
   This all **should** be possible with the standard way how Github Actions python regular projects are run https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python and we even could have a separate workflow for it. GitHubActions has full support for running the jobs on windows runners, so it does not seem that woudl require a lot of effort. The only real effort will be to fix (or deliberatly skip if we have good reason) all the tests which will be failing.
   
   WDYT?
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org