[GitHub] [airflow] mik-laj commented on a change in pull request #17160: Google Ads Hook: Support newer versions of the google-ads library

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #17160:
URL: https://github.com/apache/airflow/pull/17160#discussion_r675205605



##########
File path: airflow/providers/google/CHANGELOG.rst
##########
@@ -21,6 +21,22 @@ Changelog
 4.1.0
 .....
 
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+* ``Updated GoogleAdsHook to support newer API versions after google deprecated v5. Google Ads v8 is the new default API. (#17111)``
+
+.. warning:: The underlying google-ads library had breaking changes.
+   
+   Previously the google ads library returned data as native protobuf messages. Now it returns data as proto-plus objects that behave more like conventional Python objects. 
+
+   To preserve compatibility the hook's `search()` converts the data back to native protobuf before returning it. Your existing operators *should* work as before, but due to the urgency of the v5 API being deprecated it was not tested too thoroughly. Therefore you should carefully evaluate your operator and hook functionality with this new version.
+
+   In order to use the API's new proto-plus format, you can use the `search_proto_plus()` method.
+
+   For more information, please consult google's migration document: https://developers.google.com/google-ads/api/docs/client-libs/python/library-version-10

Review comment:
       ```suggestion
      For more information, please consult `google-ads migration document <https://developers.google.com/google-ads/api/docs/client-libs/python/library-version-10>`__: 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org