You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Zhou <ja...@gmail.com> on 2024/06/18 23:15:15 UTC
Review Request 75058: [mac] support constructing net::MAC object from sa_data char[14] array
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75058/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
When using ioctl, we get a char[14] sa_data array that holds the information necessary to construct a net::MAC object, this patch adds support for using the sa_data field to directly create a net::MAC object
Diffs
-----
3rdparty/stout/include/stout/mac.hpp 298cc142284c5cfec26c3618e13dfc27dba67e23
3rdparty/stout/tests/mac_tests.cpp ebd50a00585ef37ea2fa244d48bdd90036040258
Diff: https://reviews.apache.org/r/75058/diff/1/
Testing
-------
Thanks,
Jason Zhou
Re: Review Request 75058: [mac] support constructing net::MAC object from sa_data char[14] array
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75058/#review226573
-----------------------------------------------------------
Ship it!
Will clean up the trailing whitespace and comments on commit.
I guess we didn't need the templatization anymore since we ended up keeping the uint8_t constructor, so we could either:
* Templatize uint8_t constructor to support different array sizes, or
* Un-templatize char constructor to only support char[14]
But will land as is for now.
- Benjamin Mahler
On June 18, 2024, 11:15 p.m., Jason Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75058/
> -----------------------------------------------------------
>
> (Updated June 18, 2024, 11:15 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When using ioctl, we get a char[14] sa_data array that holds the information necessary to construct a net::MAC object, this patch adds support for using the sa_data field to directly create a net::MAC object
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/mac.hpp 298cc142284c5cfec26c3618e13dfc27dba67e23
> 3rdparty/stout/tests/mac_tests.cpp ebd50a00585ef37ea2fa244d48bdd90036040258
>
>
> Diff: https://reviews.apache.org/r/75058/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Zhou
>
>