You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/15 21:37:51 UTC

[GitHub] [incubator-mxnet] abhinavs95 opened a new pull request #14442: [MXNet-1349][WIP][Fit API]Add validation support and unit tests for fit() API

abhinavs95 opened a new pull request #14442: [MXNet-1349][WIP][Fit API]Add validation support and unit tests for fit() API
URL: https://github.com/apache/incubator-mxnet/pull/14442
 
 
   ## Description ##
   Adding validation support and unit tests for fit() API.
   This PR depends on the parent PR for fit() API #14346 
   JIRA epic: https://issues.apache.org/jira/projects/MXNET/issues/MXNET-1333
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] The PR title starts with [MXNet-1349](https://issues.apache.org/jira/browse/MXNET-1349)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   1. Added validation support in estimator class, allow users to monitor loss and metrics on validation set during training.
   2. Added unit tests for estimator and fit()
   3. Added error handlers in estimator
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services