You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/03 06:58:12 UTC
[GitHub] [incubator-nuttx-apps] anchao opened a new pull request #161:
netutils/dhcpc: configurable timeout and retry count.
anchao opened a new pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] jerpelea commented on a change in pull
request #161: netutils/dhcpc: configurable timeout and retry count.
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r403018344
##########
File path: netutils/dhcpc/dhcpc.c
##########
@@ -433,7 +433,7 @@ FAR void *dhcpc_open(FAR const char *interface, FAR const void *macaddr,
/* Configure for read timeouts */
- tv.tv_sec = 10;
+ tv.tv_sec = CONFIG_NETUTILS_DHCPC_RECV_TIMEOUT;
Review comment:
I am asking because the hard coded value was 10 sec while now the default is 3 seconds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #161: netutils/dhcpc: configurable timeout and retry count.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r403023220
##########
File path: netutils/dhcpc/dhcpc.c
##########
@@ -433,7 +433,7 @@ FAR void *dhcpc_open(FAR const char *interface, FAR const void *macaddr,
/* Configure for read timeouts */
- tv.tv_sec = 10;
+ tv.tv_sec = CONFIG_NETUTILS_DHCPC_RECV_TIMEOUT;
Review comment:
10sec for the timeout is too large for the most nowaday network, especially for DHCP transaction which always happen between two direct connected nodes without any intermediate node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] anchao commented on a change in pull request
#161: netutils/dhcpc: configurable timeout and retry count.
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r402943092
##########
File path: netutils/dhcpc/dhcpc.c
##########
@@ -433,7 +433,7 @@ FAR void *dhcpc_open(FAR const char *interface, FAR const void *macaddr,
/* Configure for read timeouts */
- tv.tv_sec = 10;
+ tv.tv_sec = CONFIG_NETUTILS_DHCPC_RECV_TIMEOUT;
Review comment:
DHCP client uses the UDP protocol to transmit, which is not reliable because sometime the dhcp request packet may not be accurately sent to the server if the signal is very weak, configurable options are also a good choose to change the behavior of dhcpc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] anchao commented on a change in pull request
#161: netutils/dhcpc: configurable timeout and retry count.
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r402943477
##########
File path: netutils/dhcpc/Kconfig
##########
@@ -16,4 +16,17 @@ config NETUTILS_DHCPC_HOST_NAME
string "DHCP client host name"
default "nuttx"
+config NETUTILS_DHCPC_RECV_TIMEOUT
+ int "Number of receive timeout in secound"
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #161: netutils/dhcpc: configurable timeout and retry count.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r403023220
##########
File path: netutils/dhcpc/dhcpc.c
##########
@@ -433,7 +433,7 @@ FAR void *dhcpc_open(FAR const char *interface, FAR const void *macaddr,
/* Configure for read timeouts */
- tv.tv_sec = 10;
+ tv.tv_sec = CONFIG_NETUTILS_DHCPC_RECV_TIMEOUT;
Review comment:
10sec for the timeout is too large for the most nowaday network, especially for DHCP transaction which always happen between two node directly without any intermediate node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #161: netutils/dhcpc: configurable timeout and retry count.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r403023220
##########
File path: netutils/dhcpc/dhcpc.c
##########
@@ -433,7 +433,7 @@ FAR void *dhcpc_open(FAR const char *interface, FAR const void *macaddr,
/* Configure for read timeouts */
- tv.tv_sec = 10;
+ tv.tv_sec = CONFIG_NETUTILS_DHCPC_RECV_TIMEOUT;
Review comment:
10sec for the timeout is too large for the most nowaday network, especially for DHCP transaction which always happen between two nodes directly without any intermediate node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] patacongo merged pull request #161:
netutils/dhcpc: configurable timeout and retry count.
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] jerpelea commented on a change in pull
request #161: netutils/dhcpc: configurable timeout and retry count.
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r402896936
##########
File path: netutils/dhcpc/Kconfig
##########
@@ -16,4 +16,17 @@ config NETUTILS_DHCPC_HOST_NAME
string "DHCP client host name"
default "nuttx"
+config NETUTILS_DHCPC_RECV_TIMEOUT
+ int "Number of receive timeout in secound"
Review comment:
typo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] jerpelea commented on a change in pull
request #161: netutils/dhcpc: configurable timeout and retry count.
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r402896853
##########
File path: netutils/dhcpc/dhcpc.c
##########
@@ -433,7 +433,7 @@ FAR void *dhcpc_open(FAR const char *interface, FAR const void *macaddr,
/* Configure for read timeouts */
- tv.tv_sec = 10;
+ tv.tv_sec = CONFIG_NETUTILS_DHCPC_RECV_TIMEOUT;
Review comment:
is there are reason for changing the 10 second dely with 3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services