[spark] branch master updated: [SPARK-28582][PYSPARK] Fix flaky test DaemonTests.do_termination_test which fail on Python 3.7

[gu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new fbeee0c  [SPARK-28582][PYSPARK] Fix flaky test DaemonTests.do_termination_test which fail on Python 3.7
fbeee0c is described below

commit fbeee0c5bcea32346b2279c5b67044f12e5faf7d
Author: WeichenXu <we...@databricks.com>
AuthorDate: Fri Aug 2 22:07:06 2019 +0900

    [SPARK-28582][PYSPARK] Fix flaky test DaemonTests.do_termination_test which fail on Python 3.7
    
    ## What changes were proposed in this pull request?
    
    Fix flaky test DaemonTests.do_termination_test which fail on Python 3.7. I add a sleep after the test connection to daemon.
    
    ## How was this patch tested?
    
    Run test
    ```
    python/run-tests --python-executables=python3.7 --testname "pyspark.tests.test_daemon DaemonTests"
    ```
    **Before**
    Fail on test "test_termination_sigterm". And we can see daemon process do not exit.
    **After**
    Test passed
    
    Closes #25315 from WeichenXu123/fix_py37_daemon.
    
    Authored-by: WeichenXu <we...@databricks.com>
    Signed-off-by: HyukjinKwon <gu...@apache.org>
---
 python/pyspark/tests/test_daemon.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/python/pyspark/tests/test_daemon.py b/python/pyspark/tests/test_daemon.py
index 2cdc16c..c987fae 100644
--- a/python/pyspark/tests/test_daemon.py
+++ b/python/pyspark/tests/test_daemon.py
@@ -47,9 +47,12 @@ class DaemonTests(unittest.TestCase):
         # daemon should accept connections
         self.assertTrue(self.connect(port))
 
+        # wait worker process spawned from daemon exit.
+        time.sleep(1)
+
         # request shutdown
         terminator(daemon)
-        time.sleep(1)
+        daemon.wait(5)
 
         # daemon should no longer accept connections
         try:


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org