You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/07/19 09:16:14 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #2911: camel-quarkus-minio: quarkus.minio.url is mandatory and still has to be valid
JiriOndrusek opened a new pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911
fixes https://github.com/apache/camel-quarkus/issues/2721
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #2911: camel-quarkus-minio: quarkus.minio.url is mandatory and still has to be valid
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911#issuecomment-882421433
Sorry, I didn't see this, I'll change title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] oscerd commented on pull request #2911: camel-quarkus-minio: quarkus.minio.url is mandatory and still has to be valid
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911#issuecomment-882420786
The title was a bit misleading.. it looks like quarkus.minio.url is always mandatory, which should be wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek edited a comment on pull request #2911: camel-quarkus-minio: quarkus.minio.url is mandatory and still has to be valid
Posted by GitBox <gi...@apache.org>.
JiriOndrusek edited a comment on pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911#issuecomment-882418320
Better explanation of `quarkus.minio.allow-empty` is - do not throw a validation exception but return `null` as a minio client if al other parameters are null (so it won't throw an exception during autowiring, if all parameters are `null`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #2911: camel-quarkus-minio: quarkus.minio.url is mandatory and still has to be valid
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911#issuecomment-882418320
Better explanation of `quarkus.minio.allow-empty` is - do not throw a validation exception but return `null` as a minio client (so it won't throw an exception during autowiring, if all parameters are `null`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek edited a comment on pull request #2911: camel-quarkus-minio: quarkus.minio.url is mandatory and still has to be valid
Posted by GitBox <gi...@apache.org>.
JiriOndrusek edited a comment on pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911#issuecomment-882418320
Better explanation of `quarkus.minio.allow-empty` is - do not throw a validation exception but return `null` as a minio client if al other parameters are null (so it won't throw an exception during autowiring, if all parameters are `null`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #2911: camel-quarkus-minio: quarkus.minio.url is not mandatory
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] oscerd commented on pull request #2911: camel-quarkus-minio: quarkus.minio.url is mandatory and still has to be valid
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911#issuecomment-882420786
The title was a bit misleading.. it looks like quarkus.minio.url is always mandatory, which should be wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #2911: camel-quarkus-minio: quarkus.minio.url is not mandatory
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #2911: camel-quarkus-minio: quarkus.minio.url is mandatory and still has to be valid
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911#issuecomment-882415507
@oscerd I'm not sure if I understand. My fix is only setting property ''quarkus.minio.allow-empty" to true, which has no effect on cases, where minio client is initialized from quarkus properties:
- if all other quarkus minio parameters are null, no minio client will be created (without it, it would throw a validation exception)
From this perspective, everything that worked before, would work after this fix.
Only difference is in the case, where all quarkus parameters are null (url, server_secret and server_access) - case of kamelet - it wouldn't throw a validation exception, but return `null` as a client. Autowiring capability of the component then would use minio client from the context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #2911: camel-quarkus-minio: quarkus.minio.url is not mandatory
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #2911: camel-quarkus-minio: quarkus.minio.url is mandatory and still has to be valid
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #2911:
URL: https://github.com/apache/camel-quarkus/pull/2911#issuecomment-882415507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org