You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Tomas Havelka (Created) (JIRA)" <de...@myfaces.apache.org> on 2012/02/16 09:54:59 UTC

[jira] [Created] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

The partialSubmit does not work with JSF 2 RI
---------------------------------------------

                 Key: TRINIDAD-2216
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Components
    Affects Versions: 2.0.0-core
         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
Glassfish 3.1.1
Trinidad 2.0.0
            Reporter: Tomas Havelka


Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:

if (typeof source === 'undefined' || source === null) {
  throw new Error("jsf.ajax.request: source not set");
} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Robert Schoch (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480838#comment-13480838 ] 

Robert Schoch edited comment on TRINIDAD-2216 at 10/21/12 1:43 PM:
-------------------------------------------------------------------

This is a code snipped from trinidad-2.0.1-api, class org.apache.myfaces.trinidad.render.CoreRenderer.java:

  ...
    /**
     * Returns true if the component should render an ID. Components
     * that deliver events should always return "true".
     */
    // TODO Is this a bottleneck?  If so, optimize!
    protected boolean shouldRenderId(
  ...

But I can not find any code that does this really what's in the comment.
Not even in the subclasses.

Patch proposal follows...

EDIT: Patch is now available, see Attachment TRINIDAD-2216-2259-2302.patch
                
      was (Author: robs888):
    This is a code snipped from trinidad-2.0.1-api, class org.apache.myfaces.trinidad.render.CoreRenderer.java:

  ...
    /**
     * Returns true if the component should render an ID. Components
     * that deliver events should always return "true".
     */
    // TODO Is this a bottleneck?  If so, optimize!
    protected boolean shouldRenderId(
  ...

But I can not find any code that does this really what's in the comment.
Not even in the subclasses.

Patch proposal follows...
                  
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>         Attachments: TRINIDAD-2216-2259-2302.patch
>
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Robert Schoch (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477890#comment-13477890 ] 

Robert Schoch edited comment on TRINIDAD-2216 at 10/20/12 7:49 PM:
-------------------------------------------------------------------

The patch, which I have attached seems to be the solution of the problem!

EDIT: removed the patch, because it works only for
  https://issues.apache.org/jira/browse/TRINIDAD-2238
The patch is available there.
                
      was (Author: robs888):
    The patch, which I have attached seems to be the solution of the problem!
                  
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Giorgos Chasapis (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453965#comment-13453965 ] 

Giorgos Chasapis commented on TRINIDAD-2216:
--------------------------------------------

I could very easy reproduce the problem. Unfortunately it was reported on February and still hasn't even been assigned to anyone.
                
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Robert Schoch (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480824#comment-13480824 ] 

Robert Schoch commented on TRINIDAD-2216:
-----------------------------------------

The renderer creates for a tr:commandButton without explicit id attribute this:

<button class="af_commandButton" onclick="TrPage._autoSubmit('TestForm','j_idt1',event,1);return false;" type="button">PPR Test</button>

You can see, that the onclick handler contains an TrPage._autoSubmit() call with a autogenerated source id as argument. This is the reason why the source is part of the payload.

But the <button> tag has no rended id attribute, so that it can never be found by the script, which searches the element in the DOM tree. This causes a null to be passed as source parameter in the jsf.ajax.request call and finally ends as error like  "jsf.ajax.request: source not set" in Mojarra.
                
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Robert Schoch (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477890#comment-13477890 ] 

Robert Schoch commented on TRINIDAD-2216:
-----------------------------------------

The patch, which I have attached seems to be the solution of the problem!
                
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>         Attachments: patch-for-XMLRequest.diff
>
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Tobias (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279222#comment-13279222 ] 

Tobias commented on TRINIDAD-2216:
----------------------------------

Hello,
looks like I have the same problem.
Environment: Tomcat 7.0.27, Servlet 2.5, com.sun.faces:jsf-impl:2.1.7, org.apache.myfaces.trinidad:trinidad-impl:2.0.1, Facelets, (tested on firefox and chrome) 

<tr:commandButton id="save" partialSubmit="true" text="save" actionListener="#{Bean.save}" />

I also think that this is causing https://issues.apache.org/jira/browse/TRINIDAD-2238
                
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Robert Schoch (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480824#comment-13480824 ] 

Robert Schoch edited comment on TRINIDAD-2216 at 10/20/12 8:46 PM:
-------------------------------------------------------------------

The renderer creates for a tr:commandButton without explicit id attribute this:

<button class="af_commandButton" onclick="TrPage._autoSubmit('TestForm','j_idt1',event,1);return false;" type="button">PPR Test</button>

You can see, that the onclick handler contains an TrPage._autoSubmit() call with a autogenerated source id as argument. This is the reason why the source is part of the payload.

But the <button> tag has no rended id attribute, so that it can never be found by the script, which searches the element in the DOM tree. This causes a null to be passed as source parameter in the jsf.ajax.request call and finally ends as error like  "jsf.ajax.request: source not set" in Mojarra.

EDIT: same problem here:

  https://issues.apache.org/jira/browse/TRINIDAD-2259
  https://issues.apache.org/jira/browse/TRINIDAD-2302
                
      was (Author: robs888):
    The renderer creates for a tr:commandButton without explicit id attribute this:

<button class="af_commandButton" onclick="TrPage._autoSubmit('TestForm','j_idt1',event,1);return false;" type="button">PPR Test</button>

You can see, that the onclick handler contains an TrPage._autoSubmit() call with a autogenerated source id as argument. This is the reason why the source is part of the payload.

But the <button> tag has no rended id attribute, so that it can never be found by the script, which searches the element in the DOM tree. This causes a null to be passed as source parameter in the jsf.ajax.request call and finally ends as error like  "jsf.ajax.request: source not set" in Mojarra.
                  
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Robert Schoch (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484836#comment-13484836 ] 

Robert Schoch commented on TRINIDAD-2216:
-----------------------------------------

Have tried the Trinidad 2.1.0 Snapshot: trinidad-api-2.1.0-20121023.010853-35.jar & trinidad-impl-2.1.0-20121023.011048-35.jar with Mojarra 2.1.13 on Tomcat 7.0.32, but there is currently another problem with the xhtml files: All Action Methods and Event Listeners are processed now as Value Expression and not as Method Expression.

This causes the following Error:

javax.el.ELException: /launch.xhtml: Property 'dialogLaunchListener' not found on type de.ospkdd.sample.DialogController
	at com.sun.faces.facelets.compiler.AttributeInstruction.write(AttributeInstruction.java:94)
	at com.sun.faces.facelets.compiler.UIInstructions.encodeBegin(UIInstructions.java:82)
	at com.sun.faces.facelets.compiler.UILeaf.encodeAll(UILeaf.java:183)
	at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1782)
	at com.sun.faces.application.view.FaceletViewHandlingStrategy.renderView(FaceletViewHandlingStrategy.java:424)
	at org.apache.myfaces.trinidad.view.ViewDeclarationLanguageWrapper.renderView(ViewDeclarationLanguageWrapper.java:101)
	at com.sun.faces.application.view.MultiViewHandler.renderView(MultiViewHandler.java:124)
	at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:288)
	...

No such ELException's with an older Snapshot! Have tried the api/impl jar's from trinidad-demo-2.1.0-20120531.161633-2.

But the original problem with the not rendered id's and the "jsf.ajax.request: source not set" still exist.

                
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>         Attachments: TRINIDAD-2216-2259-2302.patch
>
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Robert Schoch (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480838#comment-13480838 ] 

Robert Schoch commented on TRINIDAD-2216:
-----------------------------------------

This is a code snipped from trinidad-2.0.1-api, class org.apache.myfaces.trinidad.render.CoreRenderer.java:

  ...
    /**
     * Returns true if the component should render an ID. Components
     * that deliver events should always return "true".
     */
    // TODO Is this a bottleneck?  If so, optimize!
    protected boolean shouldRenderId(
  ...

But I can not find any code that does this really what's in the comment.
Not even in the subclasses.

Patch proposal follows...
                
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Robert Schoch (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Schoch updated TRINIDAD-2216:
------------------------------------

    Status: Patch Available  (was: Open)
    
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484258#comment-13484258 ] 

Scott O'Bryan commented on TRINIDAD-2216:
-----------------------------------------

Guys, before we look at committing this, have you tried the trinidad trunk to see if this is still an issue.  Technically speaking, Trinidad 2.1, not Trinidad 2.0 should be used with JSF 2.1
                
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>         Attachments: TRINIDAD-2216-2259-2302.patch
>
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TRINIDAD-2216) The partialSubmit does not work with JSF 2 RI

Posted by "Robert Schoch (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496161#comment-13496161 ] 

Robert Schoch commented on TRINIDAD-2216:
-----------------------------------------

None of the Trinidad Committers have the time to check this and integrate the patch?
                
> The partialSubmit does not work with JSF 2 RI
> ---------------------------------------------
>
>                 Key: TRINIDAD-2216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-core
>         Environment: Mojarra 2.1.6 (SNAPSHOT 20111206)
> Glassfish 3.1.1
> Trinidad 2.0.0
>            Reporter: Tomas Havelka
>         Attachments: TRINIDAD-2216-2259-2302.patch
>
>
> Trinidad's partialSubmit does not work because the source parameter passed in the jsf.ajax.request call is null. See XMLRequest.js on the line 358. The source is part of the payload but is not assigned to the source parameter itself. It causes the RI implementation of jsf.ajax.request throws an error because of this code in it:
> if (typeof source === 'undefined' || source === null) {
>   throw new Error("jsf.ajax.request: source not set");
> } 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira