You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/20 15:35:59 UTC

[GitHub] [tvm] leandron opened a new pull request, #11078: [Python] Populate setuptools description with README.md

leandron opened a new pull request, #11078:
URL: https://github.com/apache/tvm/pull/11078

   Adds the description metadata for the setuptools descriptor file `setup.py` with the contents of our existing README.md, which is a common practice.
   
   This will be reflected in the page for our package on PyPI in pages like https://pypi.org/project/apache-tvm/0.9.dev1125/
   
   cc @tqchen @areusch @Mousius @driazati @grant-arm for reviews
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #11078: [Python] Populate setuptools description with README.md

Posted by GitBox <gi...@apache.org>.
leandron commented on PR #11078:
URL: https://github.com/apache/tvm/pull/11078#issuecomment-1109455858

   https://pypi.org/project/apache-tvm/0.9.dev1166/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch merged pull request #11078: [Python] Populate setuptools description with README.md

Posted by GitBox <gi...@apache.org>.
areusch merged PR #11078:
URL: https://github.com/apache/tvm/pull/11078


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on a diff in pull request #11078: [Python] Populate setuptools description with README.md

Posted by GitBox <gi...@apache.org>.
leandron commented on code in PR #11078:
URL: https://github.com/apache/tvm/pull/11078#discussion_r857802383


##########
python/setup.py:
##########
@@ -217,6 +226,8 @@ def get_package_data_files():
     name="tvm",
     version=__version__,
     description="TVM: An End to End Tensor IR/DSL Stack for Deep Learning Systems",
+    long_description=long_description_contents(),
+    long_description_content_type="text/markdown",

Review Comment:
   Applied, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on a diff in pull request #11078: [Python] Populate setuptools description with README.md

Posted by GitBox <gi...@apache.org>.
leandron commented on code in PR #11078:
URL: https://github.com/apache/tvm/pull/11078#discussion_r857802628


##########
python/setup.py:
##########
@@ -201,6 +201,15 @@ def get_package_data_files():
     return ["relay/std/prelude.rly", "relay/std/core.rly"]
 
 
+def long_description_contents():
+    with open(
+        os.path.abspath(os.path.join(CURRENT_DIR, "..", "README.md")), encoding="utf-8"

Review Comment:
   Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Mousius commented on pull request #11078: [Python] Populate setuptools description with README.md

Posted by GitBox <gi...@apache.org>.
Mousius commented on PR #11078:
URL: https://github.com/apache/tvm/pull/11078#issuecomment-1104085396

   Much better than what we have today:
   
   ![Screenshot 2022-04-20 at 16 43 50](https://user-images.githubusercontent.com/4933431/164270331-8ddb7047-5cd4-4edb-bd24-da167a6b8a32.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] driazati commented on a diff in pull request #11078: [Python] Populate setuptools description with README.md

Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #11078:
URL: https://github.com/apache/tvm/pull/11078#discussion_r854449071


##########
python/setup.py:
##########
@@ -217,6 +226,8 @@ def get_package_data_files():
     name="tvm",
     version=__version__,
     description="TVM: An End to End Tensor IR/DSL Stack for Deep Learning Systems",
+    long_description=long_description_contents(),
+    long_description_content_type="text/markdown",

Review Comment:
   It's not strictly related but can we round out some other areas for PyPi while we're in here?
   ```suggestion
       long_description_content_type="text/markdown",
       url='https://tvm.apache.org/',
       download_url='https://github.com/apache/tvm/tags',
       author='Apache TVM',
       license='Apache',
       # See https://pypi.org/classifiers/
       classifiers=[
           "License :: OSI Approved :: Apache Software License",
           "Development Status :: 4 - Beta",
           "Intended Audience :: Developers",
           "Intended Audience :: Education",
           "Intended Audience :: Science/Research",
       ],
       keywords='machine learning',
   ```



##########
python/setup.py:
##########
@@ -201,6 +201,15 @@ def get_package_data_files():
     return ["relay/std/prelude.rly", "relay/std/core.rly"]
 
 
+def long_description_contents():
+    with open(
+        os.path.abspath(os.path.join(CURRENT_DIR, "..", "README.md")), encoding="utf-8"

Review Comment:
   nit: `pathlib` makes life easier 
   
   ```suggestion
           pathlib.Path(CURRENT_DIR).resolve().parent / "README.md", encoding="utf-8"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #11078: [Python] Populate setuptools description with README.md

Posted by GitBox <gi...@apache.org>.
areusch commented on PR #11078:
URL: https://github.com/apache/tvm/pull/11078#issuecomment-1106668899

   +1 for this, though agree with the others' comments and will let them approve


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org