You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/28 06:05:40 UTC
[GitHub] [spark] LuciferYang opened a new pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
LuciferYang opened a new pull request #31376:
URL: https://github.com/apache/spark/pull/31376
### What changes were proposed in this pull request?
Use `count` to simplify `find + size(or length)` operation, it's semantically consistent, but looks simpler.
**Before**
```
seq.filter(p).size
```
**After**
```
seq.count(p)
```
### Why are the changes needed?
Code Simpilefications.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the Jenkins or GitHub Action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768860312
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39179/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768940899
Merged to branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768842901
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39179/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768860312
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39179/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768889153
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134592/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768834068
**[Test build #134592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134592/testReport)** for PR 31376 at commit [`165a6e6`](https://github.com/apache/spark/commit/165a6e6a31c3280873d686119faa3544445f90e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768940087
I'm gonna merge this. The test failure looks unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768946034
**[Test build #134604 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134604/testReport)** for PR 31376 at commit [`165a6e6`](https://github.com/apache/spark/commit/165a6e6a31c3280873d686119faa3544445f90e7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768849559
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39179/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768889153
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134592/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768890760
**[Test build #134604 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134604/testReport)** for PR 31376 at commit [`165a6e6`](https://github.com/apache/spark/commit/165a6e6a31c3280873d686119faa3544445f90e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768924286
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39192/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768880256
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768914989
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39192/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768958758
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134604/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768924286
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39192/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768890760
**[Test build #134604 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134604/testReport)** for PR 31376 at commit [`165a6e6`](https://github.com/apache/spark/commit/165a6e6a31c3280873d686119faa3544445f90e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768834068
**[Test build #134592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134592/testReport)** for PR 31376 at commit [`165a6e6`](https://github.com/apache/spark/commit/165a6e6a31c3280873d686119faa3544445f90e7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768904371
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39192/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31376:
URL: https://github.com/apache/spark/pull/31376#issuecomment-768879350
**[Test build #134592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134592/testReport)** for PR 31376 at commit [`165a6e6`](https://github.com/apache/spark/commit/165a6e6a31c3280873d686119faa3544445f90e7).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31376: [SPARK-34275][CORE][SQL][MLLIB][2.4] Replaces filter and size with count
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31376:
URL: https://github.com/apache/spark/pull/31376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org