[Bug 6870] New: ACT_NOW_CAPS slight correction

[bu...@bugzilla.spamassassin.org]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6870

            Bug ID: 6870
           Summary: ACT_NOW_CAPS slight correction
           Product: Spamassassin
           Version: 3.3.1
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Rules
          Assignee: dev@spamassassin.apache.org
          Reporter: biggnou@gmail.com
    Classification: Unclassified

The following rule (20_phrases.cf):

body ACT_NOW_CAPS               /A(?i:ct) N(?i:ow)/

is intented to match "Act Now":

describe ACT_NOW_CAPS        Talks about 'acting now' with capitals

The regex should be corrected like:

body ACT_NOW_CAPS               /\bA(?i:ct) N(?i:ow)\b/

That is, enclosed within word boundaries, because this rule fires on legit
emails with the "PLEASE CONTACT NOW" phrase.

I do not say "PLEASE CONTACT NOW" is always legit, I just say the rule is
missing it's own declared target.

Regards,

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 6870] ACT_NOW_CAPS slight correction

[bu...@bugzilla.spamassassin.org]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6870

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |kmcgrail@pccc.com
         Resolution|---                         |FIXED

--- Comment #1 from Kevin A. McGrail <km...@pccc.com> ---
I don't see an issue with boundary checks but it does assume they didn't intend
to hit CONTACT NOW as you stated.  Many times I know I try and write
"efficient" rules that will hit on multiple items.  But I also focus a lot on
meta rules.

svn commit -m 'Bug 6870 adding boundaries for ACT_NOW_CAPS' 
Sending        rules/20_phrases.cf
Transmitting file data .
Committed revision 1415751.

-- 
You are receiving this mail because:
You are the assignee for the bug.