[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3428: ARTEMIS-3075 Skip temporary queues scale down

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3428:
URL: https://github.com/apache/activemq-artemis/pull/3428#discussion_r568963622



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScaleDownHandler.java
##########
@@ -124,9 +124,11 @@ public long scaleDownMessages(ClientSessionFactory sessionFactory,
                for (Binding binding : bindings.getBindings()) {
                   if (binding instanceof LocalQueueBinding) {
                      Queue queue = ((LocalQueueBinding) binding).getQueue();
-                     // as part of scale down we will cancel any scheduled message and pass it to theWhile we scan for the queues we will also cancel any scheduled messages and deliver them right away
-                     queue.deliverScheduledMessages();
-                     queues.add(queue);
+                     if (!queue.isTemporary()) {
+                        // as part of scale down we will cancel any scheduled message and pass it to theWhile we scan for the queues we will also cancel any scheduled messages and deliver them right away
+                        queue.deliverScheduledMessages();

Review comment:
       this should handle only scheduled messages...
   
   what about scaleDownRegularMessages? 
   
   or this issue is only only temporary messages?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org