You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/08/15 19:09:59 UTC

[GitHub] [helix] jiajunwang opened a new pull request #413: Add cluster level default instance config.

jiajunwang opened a new pull request #413: Add cluster level default instance config.
URL: https://github.com/apache/helix/pull/413
 
 
   ### Issues
   
   - [ ] My PR addresses the following Helix issues and references them in the PR title:
   
   #412
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   Add cluster level default instance config.
   This config will be applied to the instance when there is no (or empty) capacity configuration in the Instance Config.
   Also add unit tests.
   
   ### Tests
   
   - [ ] The following tests are written for this issue:
   
   TestAssignableNode
   TestClusterModel
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   NA since the WAGED rebalancer has not been integrated yet.
   
   ### Commits
   
   - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation in the following wiki page:
   
   https://github.com/apache/helix/wiki/Weight-aware-Globally-Evenly-distributed-Rebalancer
   
   ### Code Quality
   
   - [ ] My diff has been formatted using helix-style.xml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org