[GitHub] [sedona] jiayuasu commented on a diff in pull request #779: [SEDONA-244 & SEDONA-246] R align spark_read/write functions

["jiayuasu (via GitHub)" <gi...@apache.org>]

jiayuasu commented on code in PR #779:
URL: https://github.com/apache/sedona/pull/779#discussion_r1120613430


##########
R/apache.sedona.Rproj:
##########
@@ -0,0 +1,17 @@
+Version: 1.0
+

Review Comment:
   Is this a file auto-generated by Rstudio or something else. If so, can you please remove it?



##########
R/R/apache.sedona-package.R:
##########
@@ -0,0 +1,7 @@
+#' @keywords internal

Review Comment:
   Is this needed?



##########
R/DESCRIPTION:
##########
@@ -28,11 +28,14 @@ Depends:
 Imports:
     rlang,
     sparklyr (>= 1.3),

Review Comment:
   In the R folder, can you try to run the following commands? Will it pass without any warning?
   
   ```
   R CMD build .
   R CMD check --as-cran apache.sedona_*.tar.gz
   ```



##########
R/DESCRIPTION:
##########
@@ -1,7 +1,7 @@
 Type: Package
 Package: apache.sedona
 Title: R Interface for Apache Sedona
-Version: 1.3.1

Review Comment:
   Is there a reason why you use 1.3.1.9000?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org