You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mateiz <gi...@git.apache.org> on 2014/03/17 01:42:42 UTC

[GitHub] spark pull request: SPARK-1240: handle the case of empty RDD when ...

Github user mateiz commented on the pull request:

    https://github.com/apache/spark/pull/135#issuecomment-37777310
  
    Actually sorry, one other thought -- instead of throwing an error when `fraction == 0`, just return the empty array there too. Some code might pass 0 for a valid reason (e.g. if the sampling rate is coming from a user, or whatever).
    
    Anyway both this and the empty RDD case are good catches.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---