You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/02 20:09:07 UTC
[GitHub] [iceberg] samredai commented on a diff in pull request #4665: Docs:Modify the flink version from 0.11.1 to 0.14.0 and fix several errors.
samredai commented on code in PR #4665:
URL: https://github.com/apache/iceberg/pull/4665#discussion_r863151611
##########
docs/flink/flink-getting-started.md:
##########
@@ -406,7 +407,7 @@ Those are the options that could be set in flink SQL hint options for streaming
## Writing with SQL
-Iceberg support both `INSERT INTO` and `INSERT OVERWRITE` in flink 1.11 now.
+Iceberg support both `INSERT INTO` and `INSERT OVERWRITE` in flink 1.14 now.
Review Comment:
```suggestion
Iceberg supports both `INSERT INTO` and `INSERT OVERWRITE` in flink 1.14.
```
##########
docs/flink/flink-getting-started.md:
##########
@@ -334,12 +335,12 @@ CREATE TABLE `hive_catalog`.`default`.`sample` (
CREATE TABLE `hive_catalog`.`default`.`sample_like` LIKE `hive_catalog`.`default`.`sample`;
```
-For more details, refer to the [Flink `CREATE TABLE` documentation](https://ci.apache.org/projects/flink/flink-docs-release-1.11/dev/table/sql/create.html#create-table).
+For more details, refer to the [Flink `CREATE TABLE` documentation](https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/table/sql/create/).
### `ALTER TABLE`
-Iceberg only support altering table properties in flink 1.11 now.
+Iceberg only support altering table properties in flink 1.14 now.
Review Comment:
```suggestion
Iceberg only supports altering table properties in flink 1.14.
```
##########
docs/flink/flink-getting-started.md:
##########
@@ -300,9 +301,9 @@ CREATE TABLE `hive_catalog`.`default`.`sample` (
);
```
-Table create commands support the most commonly used [flink create clauses](https://ci.apache.org/projects/flink/flink-docs-release-1.11/dev/table/sql/create.html#create-table) now, including:
+Table create commands support the most commonly used [flink create clauses](https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/table/sql/create/) now, including:
Review Comment:
```suggestion
Table create commands support the most commonly used [flink create clauses](https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/table/sql/create/), including:
```
(nit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org